Skip to content

Fixing UI file navigation in README#952

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
chandanasirigineedi:readme-nav-fix
Apr 10, 2025
Merged

Fixing UI file navigation in README#952
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
chandanasirigineedi:readme-nav-fix

Conversation

@chandanasirigineedi
Copy link
Copy Markdown
Contributor

Description

This PR updates the README.md to correct the UI documentation. The previous documentation referenced an outdated or incorrect folder structure, which could mislead developers by pointing them to invalid paths.

How Has This Been Tested?

NA

Merge criteria:

  • [X ] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes
NA

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@lucferbux
Copy link
Copy Markdown
Contributor

@chandanasirigineedi can you sign off your commit? git commit --amend --signoff & git push -f, thanks a lot for the feedback, once it's done I'll approve it!

Signed-off-by: Chandana Sirigineedi <chandanasirigineedi96@gmail.com>
@chandanasirigineedi
Copy link
Copy Markdown
Contributor Author

chandanasirigineedi commented Apr 9, 2025

cc @Al-Pragliola @andreyvelich @tarilabs @lucferbux Can you guys take a look at it please?

@rareddy
Copy link
Copy Markdown
Contributor

rareddy commented Apr 9, 2025

/lgtm

Thanks for the contribution @chandanasirigineedi

Copy link
Copy Markdown
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola, lucferbux, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 62e6687 into kubeflow:main Apr 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants