Skip to content

chore(labextension): remove commented-out MUI v4 blocks#765

Open
ai-naymul wants to merge 5 commits intokubeflow:mainfrom
ai-naymul:fix/remove-commented-mui-v4-code
Open

chore(labextension): remove commented-out MUI v4 blocks#765
ai-naymul wants to merge 5 commits intokubeflow:mainfrom
ai-naymul:fix/remove-commented-mui-v4-code

Conversation

@ai-naymul
Copy link
Copy Markdown
Contributor

@ai-naymul ai-naymul commented Apr 17, 2026

Fixes #502.

Each of Select, SelectMulti, Input, ExperimentInput, and AdvancedSettings has a large block of the old MUI v4 makeStyles implementation commented out at the top of the file, preserved as reference when the migration to MUI v7 styled components happened. Removing them now, the live code below each block is what's actually in use.

about 530 lines across 5 files, pure deletion.

cc @jesuino @ederign @StefanoFioravanzo @ada333

Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stefanofioravanzo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Collaborator

@ada333 ada333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but just to be safe we need to agree that this code will never be useful

@ai-naymul
Copy link
Copy Markdown
Contributor Author

ai-naymul commented Apr 18, 2026

@ada333 agreed. each block is the pre-migration MUI v4 makeStyles version of the same component, and the live MUI v7 styled() code directly below each block is the replacement. the old code also imports from @material-ui/core which isn't a dependency anymore.

git history keeps the reference if anyone ever wants to look at it.

cc @jesuino @StefanoFioravanzo @ederign for a second look before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] Remove unused and deprecated code from labextension

2 participants