chore(labextension): remove commented-out MUI v4 blocks#765
chore(labextension): remove commented-out MUI v4 blocks#765ai-naymul wants to merge 5 commits intokubeflow:mainfrom
Conversation
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
Signed-off-by: Naymul Islam <naymul504@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ada333
left a comment
There was a problem hiding this comment.
LGTM - but just to be safe we need to agree that this code will never be useful
|
@ada333 agreed. each block is the pre-migration MUI v4 makeStyles version of the same component, and the live MUI v7 styled() code directly below each block is the replacement. the old code also imports from @material-ui/core which isn't a dependency anymore. git history keeps the reference if anyone ever wants to look at it. cc @jesuino @StefanoFioravanzo @ederign for a second look before merge. |
Fixes #502.
Each of Select, SelectMulti, Input, ExperimentInput, and AdvancedSettings has a large block of the old MUI v4 makeStyles implementation commented out at the top of the file, preserved as reference when the migration to MUI v7 styled components happened. Removing them now, the live code below each block is what's actually in use.
about 530 lines across 5 files, pure deletion.
cc @jesuino @ederign @StefanoFioravanzo @ada333