Update knative to Release 0.8#282
Update knative to Release 0.8#282k8s-ci-robot merged 3 commits intokserve:masterfrom johnugeorge:release-0.8
Conversation
|
/cc @yuzisun |
|
Great work Johnu. I imagine there will be a followon CL deprecating the use of the alpha packages "knservingv1alpha1"? |
|
@ellis-bigelow knative still defaults to v1alpha1 in the release 0.8 - https://github.com/knative/serving/releases/download/v0.8.0/serving.yaml |
| # TBD @jinchihe: This should be updated from knative (PR: https://github.com/knative/pkg/pull/510). | ||
| sed -i '/^type Condition struct {/i // +k8s:openapi-gen=true' vendor/github.com/knative/pkg/apis/condition_types.go | ||
| sed -i '/^type VolatileTime struct {/i // +k8s:openapi-gen=true' vendor/github.com/knative/pkg/apis/volatile_time.go | ||
| sed -i '/^type Condition struct {/i // +k8s:openapi-gen=true' vendor/knative.dev/pkg/apis/condition_types.go |
There was a problem hiding this comment.
these two sed lines can be removed now right @jinchihe ?
There was a problem hiding this comment.
I think so. However, my openapi-gen changes are only to have successful build. Once this is merged, @jinchihe can make specific changes for openapi-gen
There was a problem hiding this comment.
@yuzisun Yes, absolutely right! Will remove while updating openapi and python sdk once the PR merged, thanks!
|
|
||
| import ( | ||
| openapispec "github.com/go-openapi/spec" | ||
| spec "github.com/go-openapi/spec" |
There was a problem hiding this comment.
any reason to change this ? spec is the default alias name though.
There was a problem hiding this comment.
Same reason as above. @jinchihe will make specific changes needed for openapi-gen
There was a problem hiding this comment.
@johnugeorge If you updated the openapi_generated.go by running the script hack/update-openapigen.sh, should no changes, seems this is updated here. Personally you can leave the file, just upgrade knative, I can do this later. Or if you want to do that, I can work this with you together. Thanks.
@johnugeorge Sure, thanks! |
|
/retest |
|
Great work @johnugeorge! Looking forward to upgrading kfserving controller to use knative v1beta1 API. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Updating to release 0.8 * fix tests * Run hack/openapi-gen
Update instant-merge.yaml
5 participants
With the new release, all awaiting fixes from knative/pkg will be available.
Related:
#276 and #249
@jinchihe The openapi-codegen changes are not complete(added for successful build). Once this PR is merged, you could make the necessary changes. what do you think?
This change is