Skip to content

Conversation

@Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Jan 5, 2026

Description

Adds E2E tests and Kustomize deployment overlay for the Model Catalog Python client.

Depends on: #2065 (Python client PR)

Tests Added (catalog/clients/python/tests/)

File Coverage
test_sources.py Source listing, status, paths, merge behavior
test_models.py Model filtering, pagination, source references
test_artifacts.py Artifact filtering, ordering, custom properties
test_ordering.py Name and accuracy ordering (ASC/DESC)
test_filter_options.py Filter options, named queries validation
test_source_preview.py Stateless source preview API
fuzz_api/ Schemathesis-based API fuzzing

Kustomize Overlay (manifests/kustomize/options/catalog/overlays/e2e/)

  • kustomization.yaml - Overlay extending catalog base
  • sources.yaml - Test catalog source configuration
  • test-catalog.yaml - Test data (9 models with artifacts)
  • disabled-catalog.yaml - Disabled source test data

How Has This Been Tested?

cd catalog/clients/python
# use DOCKER=podman make deploy if using podman instead of docker
make deploy      # Creates a new KinD cluster 
make test-e2e
make deploy-cleanup

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from al-pragliola. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -0,0 +1,32 @@
"""Stateless fuzzing tests for Catalog API using Schemathesis."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already spoke with @Al-Pragliola about this, but I think that we can eliminate the existing fuzz test for the catalog that are https://github.com/opendatahub-io/model-registry/blob/main/clients/python/tests/fuzz_api/model_catalog/test_catalog_stateless.py in favor of this ones

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-catalog-e2e-tests-pr branch from cd72a17 to 61bee39 Compare January 7, 2026 17:08
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola marked this pull request as ready for review January 7, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants