Skip to content

Conversation

@zw0610
Copy link
Member

@zw0610 zw0610 commented Mar 10, 2021

Fix the missing -- before min-np and max-np.

- --min-np
- "1"
- max-np
- --max-np
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering how to support autoscale with HPA in the future. If we change the spec.replicas to 100, what will happen?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this so the example would at least work. We should probably discuss the case of HPA in a separate thread.

/approve
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d708607 into kubeflow:master Mar 10, 2021
@zw0610
Copy link
Member Author

zw0610 commented Mar 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants