Skip to content

Conversation

@carmark
Copy link
Member

@carmark carmark commented May 19, 2021

fix #359

Signed-off-by: Lei Xue <vfs@live.com>
@google-cla
Copy link

google-cla bot commented May 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

k8s.io/klog v1.0.0
k8s.io/kube-openapi v0.0.0-20200410163147-594e756bea31
k8s.io/sample-controller v0.0.0-00010101000000-000000000000
k8s.io/sample-controller v0.16.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need sampler controller?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// set up signals so we handle the first shutdown signal gracefully
stopCh := signals.SetupSignalHandler()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to get rid of it? Feels a little weird to rely on it.

@gaocegege
Copy link
Member

/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging for now to unblock the existing issue. Let's track the issue with sample controller separately.

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan terrytangyuan merged commit 336fa6d into kubeflow:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed to go get github.com/kubeflow/mpi-operator (invalid version: unknown revision 000000000000)

4 participants