feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Add MUI Support #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
force-pushed
the
RHOAI-17686
branch
from
2aa7ec2 to
30910cc
Compare
paulovmr
suggested changes
Jan 21, 2025
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
Thanks for the PR @jenny-s51 ! Changes look OK to me, if you could please just run the eslint with npm run test:fix in the workspaces/frontend directory and commit the changes, it will fix the some formatting issues.
jenny-s51
force-pushed
the
RHOAI-17686
branch
from
30910cc to
b676c90
Compare
…pport Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply env var to activate MUI theme remove masthead toggle, fix padding add bottom padding Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply latest changes from MR and npm run test:fix
jenny-s51
force-pushed
the
RHOAI-17686
branch
from
74de035 to
16b3864
Compare
paulovmr
approved these changes
Jan 22, 2025
ederign
approved these changes
Jan 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Great to see you contributing @jenny-s51 ! |
Member
|
/lgtm |
This was referenced Feb 14, 2025
Mohamed-ben-khemis
pushed a commit
to Mohamed-ben-khemis/notebooks
that referenced
this pull request
Mar 13, 2025
…pport (kubeflow#183) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply env var to activate MUI theme remove masthead toggle, fix padding add bottom padding Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply latest changes from MR and npm run test:fix
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
…pport (kubeflow#183) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply env var to activate MUI theme remove masthead toggle, fix padding add bottom padding Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply latest changes from MR and npm run test:fix Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
…pport (kubeflow#183) Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply env var to activate MUI theme remove masthead toggle, fix padding add bottom padding Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> apply latest changes from MR and npm run test:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MUI support to Notebooks 2.0 UI. Applies theming to Workspaces table.
Before:
After:
