feat(ws): use workspace counts from API response #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
google-oss-prow
bot
added
area/frontend
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
yashpal2104
pushed a commit
to yashpal2104/notebooks
that referenced
this pull request
Sep 7, 2025
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #418
This pull request introduces enhancements to the workspace management system, focusing on improving the handling of workspace counts, adding support for cluster metrics, and improving test coverage. The key changes include updating the
useWorkspaceCountPerKindhook to use the data provided by the backend instead of manually calculating them, adding cluster metrics to workspace-related types, and introducing tests for workspace count calculations.Also in this PR:
NamespaceContextProviderto ensure the last used namespace is valid and falls back to the first available namespace if necessary.WorkspaceKindDetailsTablewhererowPages[page - 1]could be undefined, preventing runtime errors. The empty state will be addressed in [TASK] Create Empty State for WorkspaceKinds Detail Table #504.