chore: add andyatmiami as approval for backend and controller #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
size/XS
area/backend
google-oss-prow
bot
requested review from
andyatmiami,
kimwnasptd and
thesuperzapper
google-oss-prow
bot
added
area/controller
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
ederign
force-pushed
the
add-andy-as-approval
branch
from
400aa7a to
b1039d0
Compare
Member
|
Thanks for raising this @ederign! I am very pleased to add @andyatmiami as approver on backend, controller, and CI/CD for Notebooks 2.0 given his extensive work in the last few months, this has been a long time coming! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/ok-to-test |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andy has been doing excellent work on Notebooks, as shown by his extensive contributions (v1 v2).
His consistent, high-quality contributions and deep understanding of the project make him a strong candidate to become a maintainer/approver for the Notebooks 2.0 backend and controller. I’m happy to propose him for this role formally.