fix: controller make deploy set image #643
Conversation
related: kubeflow#596 When refactoring the controller manifests - a change was missed to ensure the `make deploy` command - which calls `kustomize edit set image ...` properly replaces the `controller` `image` reference. In line with `backend` and `frontend` - the manifest should initially just specify `workspaces-controller` as the image name - and that _exact value_ should then be used in `kustomize edit set image`. This commit brings that alignment into place. Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
google-oss-prow
bot
added
the
area/controller
|
/ok-to-test |
VerificationResult of running 
Result of running 
|
|
@harshad16: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@andyatmiami: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
google-oss-prow
bot
merged commit fd7a3d8
into
kubeflow:notebooks-v2
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
3 participants
related: #596
When refactoring the controller manifests - a change was missed to ensure the
make deploycommand - which callskustomize edit set image ...properly replaces theworkspaces-controllerimagereference.In line with
backendandfrontend- the manifest should initially just specifyworkspaces-controlleras the image name - and that exact value should then be used inkustomize edit set image.This commit brings that alignment into place.