chore(manifests): remove empty emissary overlay aliases

[Raakshass]

Pull Request Template for Kubeflow Pipelines

✏️ Summary of Changes

Consolidates three manifest cleanup PRs into one, removing all deprecated/dead overlay artifacts:

Change	Origin
Delete env/platform-agnostic-emissary overlay alias (pass-through to platform-agnostic)	this PR
Delete env/platform-agnostic-multi-user-emissary overlay alias (pass-through to platform-agnostic-multi-user)	this PR
Remove emissary overlay refs from hack/test.sh	this PR
Delete env/platform-agnostic-multi-user-legacy overlay	from #12993
Remove dead executor variation section from README.md	from #12981, expanded per Julius's review to drop the entire section

Why: Emissary is the only supported executor. The -emissary overlays were zero-config pass-throughs, -legacy was a deprecated variant, and the README section referenced directories that no longer exist after this cleanup.

After this PR, surviving overlays:

• env/platform-agnostic (standalone)
• env/platform-agnostic-multi-user (multi-user)

📦 Dependencies / Related Issues

• Supersedes docs(manifests): remove dead env/platform-agnostic-pns reference from README #12981 (README cleanup) — closed
• Supersedes chore(manifests): remove deprecated legacy multi-user overlay #12993 (legacy overlay removal) — closed
• Follow-up to Julius's overlay consolidation direction in docs(manifests): remove dead env/platform-agnostic-pns reference from README #12981

✅ Contributor Checklist

• All commits are signed-off to satisfy the DCO check
• git grep returns zero hits for all removed overlay names
• No functional changes — removing dead/deprecated artifacts only
• hack/test.sh updated to remove deleted overlay references

Signed-off-by: Siddhant Jain siddhantjainofficial26@gmail.com

[google-oss-prow]

Hi @Raakshass. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Copilot]

Pull request overview

This PR removes two redundant “-emissary” kustomize overlay aliases that were historical pass-throughs, and updates the kustomize hydration test script to stop referencing them.

Changes:

• Delete env/platform-agnostic-emissary and env/platform-agnostic-multi-user-emissary overlay kustomizations (pure aliases).
• Update manifests/kustomize/hack/test.sh to remove those overlays from hydration test arrays.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
manifests/kustomize/hack/test.sh	Removes deleted overlays from the hydration test path lists.
manifests/kustomize/env/platform-agnostic-emissary/kustomization.yaml	Deleted empty alias overlay pointing to ../platform-agnostic.
manifests/kustomize/env/platform-agnostic-multi-user-emissary/kustomization.yaml	Deleted empty alias overlay pointing to ../platform-agnostic-multi-user.

[hbelmiro]

/ok-to-test

[Raakshass]

/retest

[juliusvonkohout]

Is there any documentation we need to update @hbelmiro @droctothorpe otherwise I
/approve
and waiting for your lgtm.

@Raakshass do not use merge from master, only rebase.

[juliusvonkohout]

Maybe merge most of the cleanup PRs as @hbelmiro suggested

[Raakshass]

combining #12981 and #12993 into this pr per hbelmiro's suggestion. on docs — the readme reference is covered by the #12981 changes i'm folding in, no other docs need updating. also switching to rebase-only going forward per your earlier note. will push the combined changes shortly.

[droctothorpe]

Is there any documentation we need to update @hbelmiro @droctothorpe otherwise I /approve and waiting for your lgtm.

@Raakshass do not use merge from master, only rebase.

The only emissary references are v1 specific so I think we're good on doc updates.

Please post in the #kubeflow-pipelines channel in the CNCF slack and tag me once CI passes, @Raakshass. Thanks!

[Raakshass]

rebased to master c656be4 → 9915121.
also flattened the merge commit you flagged ("do not use merge from master, only rebase") — history is now clean linear: 3 commits on top of master. CI re-running.
combined scope (from #12981 + #12993):

• delete emissary overlay aliases + refs from hack/test.sh (original)
• delete legacy multi-user overlay (from chore(manifests): remove deprecated legacy multi-user overlay #12993)
• remove dead executor section from README (from docs(manifests): remove dead env/platform-agnostic-pns reference from README #12981)
  needs /lgtm to merge.
  /retest

[abdullahpathan22]

Hello @juliusvonkohout / @Raakshass,

Thanks for consolidating these cleanup tasks into one PR, @Raakshass!.

However, since env/platform-agnostic-emissary and env/platform-agnostic-multi-user-emissary were widely used as remote Kustomize bases by the community, deleting them outright is a breaking change.

To land this PR safely, we should do the following:

1. Add a migration note

We should update manifests/kustomize/README.md to explicitly tell users what happened to the -emissary paths and what they should use instead. Here is a suggested update for the Customize section:

### Customize

> **Note on Executor Variants:** Emissary is now the default and only supported executor.
> The `env/platform-agnostic-emissary` and `env/platform-agnostic-multi-user-emissary` overlay directories have been removed.
> If you were previously using either of those as a remote Kustomize base, update your `kustomization.yaml` to point directly to `env/platform-agnostic` or `env/platform-agnostic-multi-user` respectively.

2. Add a CHANGELOG / release note entry

We need an explicit entry flagging this as a breaking change for anyone consuming the Kustomize manifests externally. Something like:

## Breaking Changes
- Removed `env/platform-agnostic-emissary` and `env/platform-agnostic-multi-user-emissary` Kustomize overlays.
  These were pass-through aliases for `env/platform-agnostic` and `env/platform-agnostic-multi-user`.
  Emissary is now the default executor built into the base manifests — no separate overlay is required.
  Update any external `kustomization.yaml` `resources:` or `bases:` references accordingly.
- Removed `env/platform-agnostic-multi-user-legacy` overlay (deprecated variant, no migration path needed).

3. Coordinate the upstream sync

Once we're aligned on the above, I can help open a corresponding PR on kubeflow/manifests to migrate our bases before this lands — that way the main Kubeflow distribution stays green through the transition.

Please do let me know if you need any help going forward!

[juliusvonkohout]

/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• manifests/kustomize/OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsonmp-k8]

/retest

[jsonmp-k8]

/lgtm

[jsonmp-k8]

/retest

[Raakshass]

thank you!