editor: do getChart in LoadEditorModel#175
Merged
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
LoadResourceEditorModel now calls the exported LoadEditorModel, and LoadEditorModel resolves and pulls the chart (getChart) before delegating the AppRelease read + manifest build to loadEditorModel. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
editor-load-model-refactor
branch
from
e9505df to
983bf08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
pkg/editor/chart_template.go:LoadResourceEditorModelnow calls the exportedLoadEditorModel(instead of the unexported helper).LoadEditorModelresolves + pulls the chart (getChart), then delegates the AppRelease read +EditorChartValueManifesttoloadEditorModel.go build ./pkg/editor/passes.