-
Notifications
You must be signed in to change notification settings - Fork 118
Use content pages without versioning #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@serg Is it possible to attach images of how this would look like in the Homepage and in the dedicated page? |
|
@moadqassem, for image we need to add |
@serg that should be possible since we already have the logo for OSM https://github.com/kubermatic/docs/blob/master/_content/operatingsystemmanager/master/img/operating-system-manager-logo.png |
|
Yes, but this image is huge in size and contain transparent spaces around actual content of the image. This image definitely should be minified and, possible, the whitespaces needs to be trimmed. |
|
@ahmedwaleedmalik I have added your image at this path /static/img/operatingsystemmanager/common/operating-system-manager-logo.png and reuse it in page content and on homepage. |
|
@serg let's merge this :D |
Signed-off-by: serg <contact@sergfurtak.com>
Signed-off-by: serg <contact@sergfurtak.com>
|
/assign @ahmedwaleedmalik |
ahmedwaleedmalik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
LGTM label has been added. Git tree hash: c5955c33d0973ac6b4f4f986390698a8b7a28152
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, serg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.