Skip to content

Conversation

@serg
Copy link
Contributor

@serg serg commented Aug 29, 2022

No description provided.

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 29, 2022
@serg serg changed the title [WIP] Use content pages without versions [WIP] Use content pages without versioning Aug 29, 2022
@moadqassem
Copy link
Member

@serg Is it possible to attach images of how this would look like in the Homepage and in the dedicated page?

@serg
Copy link
Contributor Author

serg commented Aug 30, 2022

@moadqassem, for image we need to add logo field under operatingsystemmanager key inside data/products.yaml as for other products.

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Aug 31, 2022

@moadqassem, for image we need to add logo field under operatingsystemmanager key inside data/products.yaml as for other products.

@serg that should be possible since we already have the logo for OSM https://github.com/kubermatic/docs/blob/master/_content/operatingsystemmanager/master/img/operating-system-manager-logo.png

@serg
Copy link
Contributor Author

serg commented Sep 6, 2022

Yes, but this image is huge in size and contain transparent spaces around actual content of the image. This image definitely should be minified and, possible, the whitespaces needs to be trimmed.

@serg
Copy link
Contributor Author

serg commented Oct 4, 2022

@ahmedwaleedmalik I have added your image at this path /static/img/operatingsystemmanager/common/operating-system-manager-logo.png and reuse it in page content and on homepage.

@ahmedwaleedmalik
Copy link
Member

@serg let's merge this :D

serg added 2 commits November 28, 2022 11:47
Signed-off-by: serg <contact@sergfurtak.com>
Signed-off-by: serg <contact@sergfurtak.com>
@serg serg changed the title [WIP] Use content pages without versioning Use content pages without versioning Nov 28, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2022
@serg
Copy link
Contributor Author

serg commented Nov 28, 2022

/assign @ahmedwaleedmalik

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5955c33d0973ac6b4f4f986390698a8b7a28152

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, serg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@kubermatic-bot kubermatic-bot merged commit 88e4d1c into kubermatic:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants