Feature/some refactoring #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@guusvw rebase please Has this been tested? |
Contributor
Author
|
(Rebase )Will do it and I will also write an test for |
Contributor
|
We indeed are missing some tests |
guusvw
force-pushed
the
feature/some-refactoring
branch
from
b021721 to
575f3a3
Compare
| AddToScheme(scheme) | ||
| } | ||
|
|
||
| // AddToScheme adds all types of this clientset into the given scheme. This allows composition |
Contributor
There was a problem hiding this comment.
everything under pkg/client is generated code
guusvw
force-pushed
the
feature/some-refactoring
branch
2 times, most recently
from
876c43c to
2cdd19c
Compare
mrIncompetent
suggested changes
Jan 10, 2018
| func EnsureSSHKeypairSecret(client kubernetes.Interface) (*rsa.PrivateKey, error) { | ||
| if client == nil { | ||
| return nil, fmt.Errorf("got an nil k8s client") | ||
| } |
Contributor
There was a problem hiding this comment.
Do we really wan to do a nil check?
Contributor
Author
There was a problem hiding this comment.
Yes ;) make the code more stable
| return nil, fmt.Errorf("key data not found in secret '%s/%s' (secret.data['%s']). remove it and a new one will be created", secret.Namespace, secret.Name, privateKeyDataIndex) | ||
| } | ||
| if len(b) == 0 { | ||
| return nil, fmt.Errorf("key data not found in secret '%s/%s' (secret.data['%s']). remove it and a new one will be created", secret.Namespace, secret.Name, privateKeyDataIndex) |
Contributor
There was a problem hiding this comment.
i would rather state something like invalid key data found
guusvw
force-pushed
the
feature/some-refactoring
branch
from
c953e3d to
d8c491c
Compare
added 2 commits
January 12, 2018 17:50
mrIncompetent
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.