Add more context to vsphere errors #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return err | ||
| return fmt.Errorf("failed to find cdrom device: %v", err) | ||
| } | ||
| cdrom.Connectable.StartConnected = true |
Contributor
There was a problem hiding this comment.
Why is this necessary?
Contributor
Author
There was a problem hiding this comment.
Its the device that contains the iso in which we put the userdata, I'd like it to be connected ;) This PR just moved that line after the error handling
Contributor
There was a problem hiding this comment.
right, didn't spotted the removal above 🤦♂️
mrIncompetent
previously approved these changes
Oct 12, 2018
mrIncompetent
approved these changes
Oct 13, 2018
Contributor
Author
|
/cherry-pick release/v0.8 |
Contributor
|
Error creating cherry-pick due to: |
alvaroaleman
added a commit
that referenced
this pull request
Oct 17, 2018
alvaroaleman
added a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: