Skip to content

Add CentOS support to VSphere #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2018
Merged

Add CentOS support to VSphere #366

merged 3 commits into from
Oct 20, 2018

Conversation

@alvaroaleman
Copy link
Contributor

@alvaroaleman alvaroaleman commented Oct 20, 2018 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #166

Special notes for your reviewer:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2018
mrIncompetent
mrIncompetent reviewed Oct 20, 2018
View reviewed changes
pkg/userdata/centos/userdata.go Outdated
curl \
ipvsadm
ipvsadm \
open-vm-tools
Copy link
Contributor

@mrIncompetent mrIncompetent Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only install it when we use vSphere as provider?
We have the cloud provider during templating available at {{ .CloudProvider }}.

So maybe doing {{ if eq .CloudProvider "vsphere" }} could do the job.
Would apply for Ubuntu as well.

In case you're up for a small cosmetic improvement ;)
Otherwise i'll issue a follow up PR

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2018
@alvaroaleman
Copy link
Contributor Author

alvaroaleman commented Oct 20, 2018

@mrIncompetent updated, PTAL

@mrIncompetent
Copy link
Contributor

mrIncompetent commented Oct 20, 2018

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2018
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, mrIncompetent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,mrIncompetent]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 5b71047 into master Oct 20, 2018
@alvaroaleman alvaroaleman deleted the centos-vsphere branch October 20, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrIncompetent mrIncompetent mrIncompetent left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mrIncompetent mrIncompetent

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test and document centos on vsphere

4 participants

@alvaroaleman @mrIncompetent @kubermatic-bot