Skip to content

Conversation

@mrIncompetent
Copy link
Contributor

What this PR does / why we need it:
Never override the hostname on AWS nodes.
Kube-Proxy uses the hostname= to lookup the corev1.Nodeobject its running on. On AWS nodes, the name of thecorev1.Node` is always the private dns name in AWS.
This is a requirement of the AWS code in kubernetes. Thus, manually overriding the hostname in the OS is not useful.
Instead if leads to the error messages:

W1023 13:23:23.835678       5 server.go:601] Failed to retrieve node info: nodes "aws-coreos-1-10-8-node-2" not found
W1023 13:23:23.835871       5 proxier.go:306] invalid nodeIP, initializing kube-proxy with 127.0.0.1 as nodeIP
NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2018
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2018
@alvaroaleman
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, mrIncompetent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,mrIncompetent]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 33a31df into master Oct 23, 2018
@mrIncompetent mrIncompetent deleted the dont-set-hostname-on-aws branch October 23, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants