Skip to content

Conversation

@mrIncompetent
Copy link
Contributor

@mrIncompetent mrIncompetent commented Dec 18, 2018

What this PR does / why we need it:
This PR adds a readme (proposal-ish) which describes a potential replacement for our node provisioning.

Topics to cover:

  • Difference with cloud-init
  • Different phases
  • Offline usage
  • Development process
NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2018
@mrIncompetent mrIncompetent changed the title add document to describe the provision command [WIP] add document to describe the provision command Dec 18, 2018
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2018
@@ -0,0 +1,77 @@
# Provisioning

This command offers all required functionality to provision an host, to join a Kubernetes cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comma it disturbs the balance of the world

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balance of the world has been recreated via 5e8b411

@mrIncompetent mrIncompetent changed the title [WIP] add document to describe the provision command add document to describe the provision command Dec 18, 2018
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2018
@alvaroaleman
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2018
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@kubermatic-bot kubermatic-bot merged commit 19dc4c6 into master Dec 18, 2018
@alvaroaleman alvaroaleman deleted the add-provision-document branch December 18, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants