Skip to content

Add swapoff to centos so kubelet starts #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2019
Merged

Add swapoff to centos so kubelet starts #504

merged 1 commit into from
Apr 22, 2019

Conversation

@deitch
Copy link
Contributor

@deitch deitch commented Apr 21, 2019

What this PR does / why we need it:

Disable swap on lentos so Kubelet starts.

We already do it for Ubuntu here for exactly the same reason, so we should do it for centos as well. As discussed with @mrIncompetent and @thz in Slack.

Using exact same language/code for centos as Ubuntu.

Disable swap on centos like on ubuntu

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2019
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 21, 2019

Hi @deitch. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2019
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2019
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 21, 2019

LGTM label has been added.

Git tree hash: 80f60bd925d86c2691946a0a9dd8bafc829bbc38

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2019
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

Actually this will fail tests, you need to update the fixtures with go test. /... - update

@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

Good catch. I need to update the expected output in the centos/testdata/*.golden files. Doing now.

@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

FYI, the error messages are not helpful. They tell you it is from helper.go, but not from centos, or which .golden file doesn't match.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2019
@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

Updated.

@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

/retest

@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2019
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 21, 2019

@deitch: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

/ok-ti-test

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2019
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

@deitch are you sure centos manages its swap via a systemd target?

@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

Sure? No. I remember it that way, but been a while since I did anything serious with centos.

@deitch
Copy link
Contributor Author

deitch commented Apr 21, 2019

are you sure centos manages its swap via a systemd target?

Actually, it doesn't. It uses the systemd-fstab-generator to generate the actual units, so does Ubuntu (well, both use systemd, so it makes sense). Either way, it should work.

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 21, 2019

/lgtm
/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2019
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 21, 2019

LGTM label has been added.

Git tree hash: 17723e73499bc2d0cb817a63f489f7c60023778d

@deitch deitch mentioned this pull request Apr 21, 2019
Merged
thz
thz reviewed Apr 21, 2019
View reviewed changes
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2019
thz
thz reviewed Apr 22, 2019
View reviewed changes
@deitch
Copy link
Contributor Author

deitch commented Apr 22, 2019

Back in for review.

@thz
Copy link
Contributor

thz commented Apr 22, 2019

/retest
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 22, 2019

LGTM label has been added.

Git tree hash: 2fbc459afeb17ce191e4aea9a193a8373d246693

@kubermatic-bot kubermatic-bot merged commit f90b359 into kubermatic:master Apr 22, 2019
@thz
Copy link
Contributor

thz commented Apr 22, 2019

/test all

@deitch deitch deleted the centos-swapoff branch April 22, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@thz thz thz left review comments

@alvaroaleman alvaroaleman alvaroaleman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thz thz

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deitch @kubermatic-bot @alvaroaleman @thz