Expand CloudConfig for GCE #528
Conversation
kubermatic-bot
added
the
release-note-none
kubermatic-bot
added
sig/cluster-management
| "local-zone = \"my-zone\"\n", | ||
| "local-zone = \"my-zone\"\n" + | ||
| "multizone = true\n" + | ||
| "regional = true\n", |
There was a problem hiding this comment.
Do we need both of these? What's the difference between multi-zone and regional?
There was a problem hiding this comment.
What's the difference between multi-zone and regional?
Referring to the docs:
- multizone clusters: "A multi-zone cluster runs nodes in multiple zones within the same region. All nodes in a single-zone or multi-zone cluster are controlled by the same cluster master.
- regional clusters: "Regional clusters distribute Kubernetes resources across multiple zones within a region. Regional cluster create three cluster masters across three zones and, by default, create nodes in three zones, or in as many zones as desired."
Do we need both of these?
And from the code in Kubernetes, if either multizone or regional is enabled, managedZones uses all zones. Multizone is mainly used only for this purpose, but regional is used a config for the gce instance interface.
I think we can remove multizone...but I'd like more eyes on this for confirming.
There was a problem hiding this comment.
Actually thinking about it, adding the option to the config struct wont harm, even if we end up not using it
/lgtm
/approve
|
LGTM label has been added. Git tree hash: af43930771d08c6b00cf6cf98195ff03b099d10e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
3 participants
Ref: kubermatic/kubermatic#3350 (comment)
/cc @alvaroaleman @themue
/assign @alvaroaleman