Allow using non default context #2354

omarkhammassi · 2022-08-30T18:02:50Z

This PR adds this ability to specify which context to try to create configuration from.

linux-foundation-easycla · 2022-08-30T18:02:53Z

The committers listed above are authorized under a signed CLA.

✅ login: omarkhammassi / name: Omar Khammassi (6bacd2a)

k8s-ci-robot · 2022-08-30T18:02:58Z

Welcome @omarkhammassi!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-08-30T18:03:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omarkhammassi
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval by writing /assign @yue9944882 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

brendandburns · 2022-08-30T20:08:09Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

              new InputStreamReader(
                  new FileInputStream(kubeConfig), StandardCharsets.UTF_8.name()))) {
-        KubeConfig kc = KubeConfig.loadKubeConfig(kubeConfigReader);
+        KubeConfig kc = KubeConfig.loadKubeConfig(kubeConfigReader, context);


Don't change this signature, just call kc.setContext(...) after the kube config is created.

+1 keep the parameter list minimal and neat

brendandburns · 2022-08-30T20:09:07Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

+    return standard(true, context);
+  }
+
+  public static ClientBuilder standard(boolean persistConfig, String context) throws IOException {


Rather than change this signature, I think we should add a context(String context) method to ClientBuilder

yue9944882 · 2022-08-31T05:45:39Z

util/src/main/java/io/kubernetes/client/util/KubeConfig.java

+    if (context != null) {
+      kubeConfig.setContext(context);
+    } else {
+      String currentContext = (String) configMap.get("current-context");


nit: promote "currrent-context" to a static final variable in this class

yue9944882 · 2022-08-31T05:46:59Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

              new InputStreamReader(
                  new FileInputStream(kubeConfig), StandardCharsets.UTF_8.name()))) {
-        KubeConfig kc = KubeConfig.loadKubeConfig(kubeConfigReader);
+        KubeConfig kc = KubeConfig.loadKubeConfig(kubeConfigReader, context);


+1 keep the parameter list minimal and neat

brendandburns · 2022-09-01T14:11:40Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java


+  public static ClientBuilder context(String context) throws IOException {
+    final File kubeConfig = getKubeConfigFile();
+    ClientBuilder clientBuilder = getClientBuilder(true, kubeConfig, context);


Don't change the signature here, just call kubeconfig.setContext(context) before you call getClientBuilder(context)

kubeConfig is of type File , setContext(context) can only be set at a later stage when building the client

brendandburns · 2022-09-01T14:13:18Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

  }

-  private static ClientBuilder getClientBuilder(boolean persistConfig, File kubeConfig)
+  private static File getKubeConfigFile() {


This is messy. We should really refactor the whole ClientBuilder class so that it defers all of this construction until the build() method is called.

That's beyond the scope of this PR though (unless you want to :)) but please add a TODO: defer construction to build() method here.

brendandburns · 2022-09-01T14:15:21Z

util/src/main/java/io/kubernetes/client/util/ClientBuilder.java

  }

+  public static ClientBuilder context(String context) throws IOException {
+    final File kubeConfig = getKubeConfigFile();


This isn't quite what I was expecting, I think that we should support ClientBuilder.standard().context("foo").build() as well as ClientBuilder.kubeconfig(someFile).context("foo").build()

I think what this means is that we need to save off the KubeConfig object in the builder rather than constructing it new each time.

k8s-triage-robot · 2022-12-01T16:26:18Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-12-31T17:16:37Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

brendandburns · 2023-01-22T00:57:41Z

Closing this PR as stale, please feel free to re-open it if you plan to work on it further.

Allow using non default context

6bacd2a

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 30, 2022

k8s-ci-robot requested review from brendandburns and yue9944882 August 30, 2022 18:03

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 30, 2022

brendandburns reviewed Aug 30, 2022

View reviewed changes

yue9944882 reviewed Aug 31, 2022

View reviewed changes

omarkhammassi added 2 commits August 31, 2022 11:58

Address comments.

ea050c6

Address comments.

0001a0b

omarkhammassi requested review from brendandburns and yue9944882 and removed request for brendandburns and yue9944882 August 31, 2022 11:19

brendandburns reviewed Sep 1, 2022

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2022

brendandburns closed this Jan 22, 2023

Allow using non default context #2354

Allow using non default context #2354

Uh oh!

Conversation

omarkhammassi commented Aug 30, 2022

Uh oh!

linux-foundation-easycla bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 30, 2022

Uh oh!

k8s-ci-robot commented Aug 30, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Dec 1, 2022

Uh oh!

k8s-triage-robot commented Dec 31, 2022

Uh oh!

brendandburns commented Jan 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla bot commented Aug 30, 2022 •

edited

Loading

brendandburns Sep 1, 2022 •

edited

Loading