WebSockets: handle onClosing

[stevenschlansker]

We are trying to use the PortForward class to communicate with our kubernetes pods for testing purposes. We've been having trouble with tunneled connections timing out or receiving unexpected EOFs. There is little documentation about how this api server proxy works, which makes diagnosing any problems a struggle.
I added voluminous debug logs and discovered that the server seems to be sending an onClosing event with a code of 1000, indicating that it will not communicate with us further in this session.
I don't understand why the api server proxy is closing our session which we intend to use further. But, if it does, it does no good to keep it open clientside: you will wait as long as you like but the server won't send any more data.

Shutting down the client side in this case seems to allow the higher levels to re-establish the connection and continue. We still have some stability problems with the PortForward, but this seems to make it significantly better.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: stevenschlansker / name: Steven Schlansker (ede316c)

[k8s-ci-robot]

Welcome @stevenschlansker!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

This looks good to me, looking at the parent code (https://github.com/square/okhttp/blob/ee1ba4656d80ed62485387217271c7fa31dc888e/okhttp/src/jvmMain/kotlin/okhttp3/WebSocketListener.kt#L20) that call to super.onClosing() isn't doing anything anyway.

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, stevenschlansker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[brendandburns]

fwiw, you shouldn't expect PortForward to run forever. It's very much intended for transient, debug/development scenarios, not persistent connections. If you want a persistent connection you should expose your application as a Service.

[stevenschlansker]

Agreed. Thank you!