Support insecure ca root validation. #32
Merged
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbohlool
reviewed
Jun 25, 2017
| // grumpy' | ||
| String caCert = config.getCertificateAuthorityData(); | ||
| String caCertFile = config.getCertificateAuthorityFile(); | ||
| if (caCert != null || caCertFile != null) { |
Contributor
There was a problem hiding this comment.
should we fail if config.verifySSL() is true and both of these two are null?
Contributor
Author
There was a problem hiding this comment.
No, because you could be using a legit well-known CA issued cert, in which case you don't have to supply your own CA root.
| } | ||
| } | ||
| } else { | ||
| client.setVerifyingSsl(false); |
Contributor
There was a problem hiding this comment.
should we also set this to true in the previous block. just to be bullet proof (e.g. somebody loading config with verifySSL false and then again with it set to true.
Contributor
Author
There was a problem hiding this comment.
This call is static and always creates both a new KubeConfig object and returns a new client, so I don't think that is a risk.
Contributor
Author
|
Comments addressed, relevant issue filed and linked. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbohlool this is needed for Bronze certification
Fixes #33