Skip to content

Conversation

@mstruebing
Copy link
Member

Rev new version to be able to publish: #2701

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 315914a into release-1.1 Nov 25, 2025
2 checks passed
@mstruebing
Copy link
Member Author

I can not release a new version - there are multiple restrictions.

  1. I think we have some kind of environment protection for the gh-pages branch (should we remove the branch and the associated actions?)
  2. The build-package.sh script executes pre-check.sh which makes sure the script is only run from the main branch.

I've tried to circumvent 1. by temporary adding the branch in the allowed branches for the production environment - which kinda worked.
Then I've got hit 2 (I think I have a Déjà vu right now) and I'm not how to proceed.

My proposal:

We change the script pre-check.sh to be allowed to run on main and release-* branches and we include the release branches also in the allowed branches for the production environment.

Otherwise we would need always manually release fixes for older versions.

What do you think?

cc @brendanburns @cjihrig

Here are the runs btw:
https://github.com/kubernetes-client/javascript/actions/runs/19671313188
https://github.com/kubernetes-client/javascript/actions/runs/19671291175

@dherbolt
Copy link
Contributor

dherbolt commented Nov 27, 2025

Any update here? I'm curious how previous versions 1.1 and 1.2 were released...
Thanks.

EDIT: Ah, I see... They were released before 1.2, so probably from the main branch.

@mstruebing
Copy link
Member Author

Exactly!
The only one who could release manually would be @brendanburns right now as he has control over the npm package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants