Skip to content

Fix a bug if the headers array is null or undefined in exec auth. #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

Fix a bug if the headers array is null or undefined in exec auth. #354

merged 1 commit into from
Oct 13, 2019

Conversation

@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Oct 13, 2019

Fixes #353

@brendandburns brendandburns requested a review from drubin October 13, 2019 17:24
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2019
@k8s-ci-robot k8s-ci-robot requested a review from mbohlool October 13, 2019 17:24
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2019
@brendandburns brendandburns mentioned this pull request Oct 13, 2019
Closed
@drubin
Copy link
Contributor

drubin commented Oct 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit ae1c897 into kubernetes-client:master Oct 13, 2019
@brendandburns brendandburns deleted the headers branch July 8, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drubin drubin Awaiting requested review from drubin

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@drubin drubin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

exec error: 'Unexpected server response: 401'

3 participants

@brendandburns @k8s-ci-robot @drubin