CoreV1APi.create_namespaced_pod() always sets "image_pull_policy" to "NotIfPresent"

[spleeeen]

What happened:
Function works as intended and sets every other value of large nested pod definition (the body arg). However, as seen in the V1Pod return value, it sets the all container.image_pull_policy values to "NotIfPresent" in the pod.spec.containers array. kubectl applyinging the generated yaml with this value changed to 'Always' succeeds in persisting it. Problem only occurs when using the python client.

Relevant Code

call to create_namespaced_pod()

definition of pod body

Excerpt of print statement

What you expected to happen:
image pull policy to be set to 'Always'

How to reproduce it (as minimally and precisely as possible):
see code

Environment:

Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.11", GitCommit:"27522a29febbcc4badac257763044d0d90c11abd", GitTreeState:"clean", BuildDate:"2021-09-15T19:16:25Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

Python 3.8.9

kubernetes==21.7.0

[showjason]

/assign

[showjason]

Hi @spleeeen , please refer to this example, it is similar to your case.
The attributes of pod belong to different models, they must be converted to model object, then unmarshal the model object into Go struct.

[spleeeen]

def pod_object(asset_name):
    env_var = client.V1EnvVar(name='CONTAINER_NAME', value=asset_name)
    limits = {'cpu': cpu_limit, 'memory': memory_limit}
    requests = {'cpu': cpu_request, 'memory': memory_request}
    resources = client.V1ResourceRequirements(limits=limits, requests=requests)
    container = client.V1Container(name=f'{asset_name}-archivist', 
                                    image=f'ntr.nwie.net/eds/anomaly-engine-archivist:{image_tag}',
                                    image_pull_policy='Always',
                                    resources=resources,
                                    env=[env_var])
    spec = client.V1PodSpec(containers=[container])
    metadata = client.V1ObjectMeta(name=f'{asset_name}-archivist', labels={'archivist': asset_name})
    return client.V1Pod(metadata=metadata, spec=spec)

After changing the code to use the client's objects it still exhibits the same behavior. Everything from the pod name to the resources and environment variables are set as specified with the exception of image_pull_policy, which is set to 'IfNotPresent' within the pod despite how it is declared.

I have read the the default for this image_pull_policy value is 'IfNotPresent' when the image tag is anything but 'latest,' in which case it defaults to 'Always.' Is this supposed default behavior somehow overwriting my declared value?

[spleeeen]

Not sure how but it worked after switching the image tag it was using to create the pod's container? Thanks

[roycaihw]

/assign @showjason
Thank you!

/close

[k8s-ci-robot]

@roycaihw: Closing this issue.

In response to this:

/assign @showjason
Thank you!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.