-
Notifications
You must be signed in to change notification settings - Fork 63
Changes in the SMB v1beta2 API #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in the SMB v1beta2 API #146
Conversation
|
The results of the tests with commit ed27d34 are: /hold This is on top of the Filesystem API changes, we should merge #143 first |
ed27d34 to
5790780
Compare
5790780 to
cbd5d19
Compare
cbd5d19 to
f826e46
Compare
|
Test results with commit f826e46: |
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Adds all the changes as per #132, also adds integration tests per API version
Which issue(s) this PR fixes:
Fixes #132
Special notes for your reviewer:
This is on top of the disk API and the volume API PRs, we should merge those first.
Does this PR introduce a user-facing change?:
/cc @jingxu97 @ddebroy