Skip to content

Conversation

@mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup
/kind feature

What this PR does / why we need it:

Adds all the changes as per #132, also adds integration tests per API version

Which issue(s) this PR fixes:

Fixes #132

Special notes for your reviewer:

This is on top of the disk API and the volume API PRs, we should merge those first.

Does this PR introduce a user-facing change?:

Added the v1beta2 SMB API, see #132 for the list of changes and the proto in client/api/smb/v1beta2

/cc @jingxu97 @ddebroy

@k8s-ci-robot k8s-ci-robot requested review from ddebroy and jingxu97 June 3, 2021 00:04
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2021
@mauriciopoppe
Copy link
Member Author

The results of the tests with commit ed27d34 are:

=== RUN   TestSmbAPIGroup
=== RUN   TestSmbAPIGroup/v1alpha1SmbTests
=== RUN   TestSmbAPIGroup/v1beta1SmbTests
=== RUN   TestSmbAPIGroup/v1beta2SmbTests
--- PASS: TestSmbAPIGroup (30.16s)
    --- PASS: TestSmbAPIGroup/v1alpha1SmbTests (12.23s)
    --- PASS: TestSmbAPIGroup/v1beta1SmbTests (8.96s)
    --- PASS: TestSmbAPIGroup/v1beta2SmbTests (8.96s)
PASS
ok      github.com/kubernetes-csi/csi-proxy/integrationtests    30.596s

/hold

This is on top of the Filesystem API changes, we should merge #143 first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 5, 2021
@mauriciopoppe
Copy link
Member Author

Test results with commit f826e46:

=== RUN   TestSmbAPIGroup
=== RUN   TestSmbAPIGroup/v1alpha1SmbTests
=== RUN   TestSmbAPIGroup/v1beta1SmbTests
=== RUN   TestSmbAPIGroup/v1beta2SmbTests
--- PASS: TestSmbAPIGroup (31.57s)
    --- PASS: TestSmbAPIGroup/v1alpha1SmbTests (13.73s)
    --- PASS: TestSmbAPIGroup/v1beta1SmbTests (8.87s)
    --- PASS: TestSmbAPIGroup/v1beta2SmbTests (8.96s)
PASS

@mauriciopoppe
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2021
@jingxu97
Copy link
Contributor

jingxu97 commented Jun 7, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit b1b655c into kubernetes-csi:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates in the SMB v1beta2 API

3 participants