GetDiskNumberWithID API

[ksubrmnn]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Implements GetDiskNumber API in Go as first step in removing dependency on diskutil.exe
Which issue(s) this PR fixes:

Fixes #51

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @ksubrmnn. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ksubrmnn]

/assign @ddebroy

[ksubrmnn]

@marosset in case you want to review

[marosset]

lgtm

[ddebroy]

/ok-to-test

[ddebroy]

Thanks for getting this up and going! A couple of suggestions:

1. The internal syscalls should be moved under internal/os/disk rather than a new internal/os/diskutil
2. Modify GetDiskNumberByName to call the APIs introduced in this PR (rather than diskutil.exe)
3. Add e2e tests (could be a separate PR) if possible. You can potentially use the registry to detect if any of the disks visible in the system has page 83 IDs or not OR opt for a filter driver to return page 83 IDs.

[ksubrmnn]

@ddebroy can you approve this? I'll follow up in a separate PR for testing/updated API

[ddebroy]

LGTM

[ddebroy]

/lgtm

[ddebroy]

/approve

[jingxu97]

/ok-to-test

[jingxu97]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, jingxu97, ksubrmnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ddebroy,jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jingxu97]

/lgtm