Update PersistentVolume and VolumeSnapshot Link #478

Kartik494 · 2021-11-24T10:05:51Z

Persistent Volume and Volume snapshot Link mention in docs is refer to 1.16 version. SO this PR updated to latest version

linux-foundation-easycla · 2021-11-24T10:06:05Z

The committers are authorized under a signed CLA.

✅ Kartik Sharma (9f3588a)

Kartik494 · 2021-11-24T10:06:05Z

/release-note-none

Kartik494 · 2021-11-25T05:58:34Z

/easycla

humblec · 2022-02-05T02:43:13Z

book/src/snapshot-restore-feature.md

 ### Snapshot APIs

-Similar to the API for managing [Kubernetes Persistent Volumes](https://v1-16.docs.kubernetes.io/docs/concepts/storage/persistent-volumes/), the Kubernetes Volume Snapshots introduce three new API objects for managing snapshots: `VolumeSnapshot`, `VolumeSnapshotContent`, and `VolumeSnapshotClass`. See [Kubernetes Snapshot documentation](https://v1-16.docs.kubernetes.io/docs/concepts/storage/volume-snapshots/) for more details.
+Similar to the API for managing [Kubernetes Persistent Volumes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/), the Kubernetes Volume Snapshots introduce three new API objects for managing snapshots: `VolumeSnapshot`, `VolumeSnapshotContent`, and `VolumeSnapshotClass`. See [Kubernetes Snapshot documentation](https://kubernetes.io/docs/concepts/storage/volume-snapshots/) for more details.


This mention is under snapshot alpha section, so we have to revisit this and also there are references below to external snapshotter 1.2 and alpha APIs..

@humblec the link mentioned in snapshot alpha section which refer to v1.16 of k8s.io persistent volume docs which i am not able to get in offical site i.e https://kubernetes.io/. Should i mentioned here a specific version of it?

Since alpha API is not widely used anymore, I would leave the link as-is ; or if you really want to put to that section you can refer to : https://github.com/kubernetes/website/blob/snapshot-initial-v1.16/content/en/docs/concepts/storage/volume-snapshots.md

Kartik494 · 2022-02-07T04:04:19Z

Added a commit for versions which still refer to v1.16 of k8s.io documentation which i am not able to get in the official https://kubernetes.io/ to the correct versions.

Kartik494 · 2022-03-30T07:10:10Z

@xing-yang @humblec Could you please take a look

k8s-triage-robot · 2022-07-26T01:42:47Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Kartik494 · 2022-07-26T03:36:43Z

/remove-lifecycle stale

k8s-triage-robot · 2022-10-24T04:32:31Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Kartik494 · 2022-10-25T09:03:03Z

/remove-lifecycle stale

k8s-triage-robot · 2023-01-23T09:54:18Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Kartik494 · 2023-01-23T10:02:54Z

/remove-lifecycle stale

k8s-triage-robot · 2023-04-23T10:03:39Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

coulof · 2023-04-25T18:52:20Z

close in favour of #562

coulof · 2023-05-02T11:45:41Z

book/src/snapshot-restore-feature.md

 ### Snapshot APIs

-Similar to the API for managing [Kubernetes Persistent Volumes](https://v1-16.docs.kubernetes.io/docs/concepts/storage/persistent-volumes/), the Kubernetes Volume Snapshots introduce three new API objects for managing snapshots: `VolumeSnapshot`, `VolumeSnapshotContent`, and `VolumeSnapshotClass`. See [Kubernetes Snapshot documentation](https://v1-16.docs.kubernetes.io/docs/concepts/storage/volume-snapshots/) for more details.
+Similar to the API for managing [Kubernetes Persistent Volumes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/), the Kubernetes Volume Snapshots introduce three new API objects for managing snapshots: `VolumeSnapshot`, `VolumeSnapshotContent`, and `VolumeSnapshotClass`. See [Kubernetes Snapshot documentation](https://kubernetes.io/docs/concepts/storage/volume-snapshots/) for more details.


Since alpha API is not widely used anymore, I would leave the link as-is ; or if you really want to put to that section you can refer to : https://github.com/kubernetes/website/blob/snapshot-initial-v1.16/content/en/docs/concepts/storage/volume-snapshots.md

k8s-ci-robot · 2023-05-02T11:45:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kartik494
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-05-02T11:45:54Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Kartik494 · 2023-05-25T14:36:20Z

/close

k8s-ci-robot · 2023-05-25T14:36:23Z

@Kartik494: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2021

k8s-ci-robot requested review from lpabon and saad-ali November 24, 2021 10:05

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2021

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2021

humblec reviewed Feb 5, 2022

View reviewed changes

Update PersistentVolume and VolumeSnapshot Link

38437a7

Kartik494 force-pushed the storageLinks branch from 9f3588a to 38437a7 Compare February 7, 2022 04:00

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2023

coulof suggested changes May 2, 2023

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023

k8s-ci-robot closed this May 25, 2023

Update PersistentVolume and VolumeSnapshot Link #478

Update PersistentVolume and VolumeSnapshot Link #478

Uh oh!

Conversation

Kartik494 commented Nov 24, 2021

Uh oh!

linux-foundation-easycla bot commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kartik494 commented Nov 24, 2021

Uh oh!

Kartik494 commented Nov 25, 2021

Uh oh!

humblec Feb 5, 2022

Choose a reason for hiding this comment

Uh oh!

Kartik494 Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coulof May 2, 2023

Choose a reason for hiding this comment

Uh oh!

Kartik494 commented Feb 7, 2022

Uh oh!

Kartik494 commented Mar 30, 2022

Uh oh!

k8s-triage-robot commented Jul 26, 2022

Uh oh!

Kartik494 commented Jul 26, 2022

Uh oh!

k8s-triage-robot commented Oct 24, 2022

Uh oh!

Kartik494 commented Oct 25, 2022

Uh oh!

k8s-triage-robot commented Jan 23, 2023

Uh oh!

Kartik494 commented Jan 23, 2023

Uh oh!

k8s-triage-robot commented Apr 23, 2023

Uh oh!

coulof commented Apr 25, 2023

Uh oh!

coulof May 2, 2023

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented May 2, 2023

Uh oh!

k8s-ci-robot commented May 2, 2023

Uh oh!

Kartik494 commented May 25, 2023

Uh oh!

k8s-ci-robot commented May 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla bot commented Nov 24, 2021 •

edited

Loading

Kartik494 Feb 7, 2022 •

edited

Loading