Skip to content

Change data-source-validator to volume-data-source-validator #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

Change data-source-validator to volume-data-source-validator #11

merged 1 commit into from
Aug 30, 2021

Conversation

@bswartz
Copy link
Contributor

@bswartz bswartz commented Aug 30, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Modify user-visible strings to match the new name.

Does this PR introduce a user-facing change?:

Image name updated to volume-data-source-manager.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2021
xing-yang
xing-yang reviewed Aug 30, 2021
View reviewed changes
cmd/volume-data-source-validator/Dockerfile Outdated
@@ -0,0 +1,7 @@
FROM gcr.io/distroless/base:latest
LABEL maintainers="Kubernetes Authors"
LABEL description="Data Source Validator Controller"
Copy link
Contributor

@xing-yang xing-yang Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Volume"?

@bswartz
Change data-source-validator to volume-data-source-validator
0f97a2a 
Modify user-visible strings to match the new name.
@xing-yang
Copy link
Contributor

xing-yang commented Aug 30, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bswartz, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4fd0709 into kubernetes-csi:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang xing-yang left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@pohly pohly Awaiting requested review from pohly

Assignees

@xing-yang xing-yang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bswartz @xing-yang @k8s-ci-robot