[release-1.27]🐞 fix: shasum in blobfuse-proxy installer for Flatcar, fix PATH in blobfuse-proxy.service #2217
Conversation
The blobfuse-proxy installer script used with Flatcar,
install-proxy-rhcos.sh, uses sha256sum to check whether blobfuse
binaries need to be (re-installed). If the checksum of blobfuse2 on the
host and blobfuse2 shipped with the container differ, the host blobfuse2
is replaced.
However, for Flatcar, we use a custom name for the blobfuse2 binary on
the host ("blobfuse2.bin") and ship a wrapper script named "blobfuse2"
to update the linker path for blobfuse2. The shasum check did not
account for this and inadvertently generated a checksum for the wrapper
script instead of the actual binary.
This change fixes that.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
k8s-ci-robot
added
kind/bug
|
Hi @t-lo. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: t-lo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
t-lo
changed the title
Commit 0f30780 corrected setting a custom PATH environment in blobfuse-proxy.service. However, the change also included a bug leading to the updated PATH never actually being added to blobfuse-proxy.service. This commit fixes that. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
k8s-ci-robot
added
size/M
t-lo
changed the title
2 participants
The blobfuse-proxy installer script used with Flatcar, install-proxy-rhcos.sh, uses sha256sum to check whether blobfuse binaries need to be (re-)installed. If the checksum of blobfuse2 on the host and blobfuse2 shipped with the container differ, the host blobfuse2 is replaced.
However, for Flatcar, we use a custom name for the blobfuse2 binary on the host ("blobfuse2.bin") and ship a wrapper script named "blobfuse2" to update the linker path for blobfuse2. The shasum check did not account for this and inadvertently generated a checksum for the wrapper script instead of the actual binary.
Additionally, it fixes an issue introduced with the original Flatcar support PR in 0f30780, which modifies the PATH environment variable correctly for
blobfuse-proxy/blobfuse-proxy.servicebut did not actually commit those changes to the service unit file.This PR fixes both.
Backport of #2216 to release-1.27.
/kind bug