-
Notifications
You must be signed in to change notification settings - Fork 81
Implements server-side apply #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mortent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. For force-conflicts I think we should just use the same approach as kubectl unless we have a good reason to do something different.
1d17700 to
9353764
Compare
d150767 to
c6e5b23
Compare
aa92e37 to
dd031b9
Compare
dd031b9 to
9928537
Compare
|
/assign @mortent |
mortent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mortent, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--server-sidetokpt live applyto turn on the server-side apply--force-conflictsbool for overwriting applied fields if field manage conflict.--field-managerstring flag to dynamically determine the applied fields "owner".