Skip to content

Export ExpandDir function and add an extra return value #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Export ExpandDir function and add an extra return value #262

merged 1 commit into from
Oct 27, 2020

Conversation

@seans3
Copy link
Contributor

@seans3 seans3 commented Oct 26, 2020 •
edited
Loading

  • Exports common.ExpandDir function.
  • Adds return value of inventory template filepath to this function, which was already being calculated.
  • Adds unit tests for this newly exported function.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2020
@seans3
Copy link
Contributor Author

seans3 commented Oct 26, 2020

/assign @mortent

mortent
mortent reviewed Oct 27, 2020
View reviewed changes
pkg/common/path.go
continue
}
path := meta.Annotations[kioutil.PathAnnotation]
path = filepath.Join(dir, path)
Copy link
Member

@mortent mortent Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for packages with subfolders? It might be worth adding a test for this.

Copy link
Contributor Author

@seans3 seans3 Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added unit test for this case.

@seans3 seans3 force-pushed the inventory-template-filepath branch from 125e8a8 to bd2b1e4 Compare October 27, 2020 17:50
@seans3 seans3 force-pushed the inventory-template-filepath branch from bd2b1e4 to 500dca1 Compare October 27, 2020 21:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2020
@mortent
Copy link
Member

mortent commented Oct 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5e68050 into kubernetes-sigs:master Oct 27, 2020
@seans3 seans3 mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortent mortent mortent left review comments

@barney-s barney-s Awaiting requested review from barney-s

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@mortent mortent

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seans3 @k8s-ci-robot @mortent