Skip to content

Conversation

@Ankitasw
Copy link
Member

What type of PR is this?
/area testing

What this PR does / why we need it:
This PR replaces use of E2E_FOCUS with GINKGO_FOCUS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@Ankitasw Ankitasw requested a review from Skarlso January 31, 2023 10:14
@Skarlso
Copy link
Contributor

Skarlso commented Jan 31, 2023

@Ankitasw What's the order here? :)) First this kubernetes/test-infra#28591 then this one, right?

So I'll approve the other one first.

@Ankitasw
Copy link
Member Author

yeah first kubernetes PR then this. 🙂

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-blocking

@Ankitasw
Copy link
Member Author

Ankitasw commented Jan 31, 2023

^^ Checking if the fix actually works in PR. Tested locally, works fine.

@Ankitasw
Copy link
Member Author

@Skarlso looks like this fix is working fine.

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-clusterclass

@Skarlso
Copy link
Contributor

Skarlso commented Jan 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@Ankitasw Ankitasw added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dbef616 into kubernetes-sigs:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants