Skip to content

Conversation

@sivchari
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12700

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2025
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Just one small finding

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

Please trigger ^ again once the finding is fixed

@fabriziopandini
Copy link
Member

lgtm as soon as the finding above is addressed

@sbueringer
Copy link
Member

@sivchari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-main-gke 50d58f1 link true /test pull-cluster-api-e2e-main-gke
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

^^ Unrelated flake, has been fixed on main

Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the pr-bump-capd-k8s-v1-35-0-beta-0 branch from 50d58f1 to 5967689 Compare November 22, 2025 12:18
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/override pull-cluster-api-e2e-main-gke

(flakes have nothing to do with this PR)

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main-gke

In response to this:

Thx!

/lgtm
/approve

/override pull-cluster-api-e2e-main-gke

(flakes have nothing to do with this PR)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6b20bd7efef91015b7ea3708040e1ab0b5382e0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Nov 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 27a242b into kubernetes-sigs:main Nov 24, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants