helm chart addition to cosi-controller #75

thotz · 2023-04-27T09:44:21Z

Creating helm charts for cosi-controller

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

k8s-ci-robot · 2023-04-27T09:44:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thotz
Once this PR has been reviewed and has the lgtm label, please assign mukhoakash for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-04-27T09:44:29Z

Welcome @thotz!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-04-27T09:44:30Z

Hi @thotz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BlaineEXE · 2023-04-27T22:18:30Z

charts/container-object-storage-interface-controller/templates/_helpers.tpl

+We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
+If release name contains chart name it will be used as a full name.
+*/}}
+{{- define "container-object-storage-interface-controller.fullname" -}}


Isn't this already starting out with 46 chars because the base name is container-object-storage-interface-controller. I wonder how detailed we all think the name should be.

Can we be as short as cosi-controller?
object(-store?)-interface?
object(-store)?-interface-controller?

I suggest that resources are named {{ template "container-object-storage-interface-controller.fullname" . }} (there is one of each kind, so no need to suffix the name.

this is how helm generate a default chart (helm create container-object-storage-interface-controller)

jouve · 2023-07-10T08:04:46Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: {{ include "container-object-storage-interface-controller.fullname" . }}-objectstorage-controller


as it's the only deployment in the release, I suggest to not add a suffix

liangyuanpeng · 2023-07-11T07:46:11Z

Link to issue #74

jouve · 2023-07-10T08:08:21Z

charts/container-object-storage-interface-controller/values.yaml

@@ -0,0 +1,8 @@
+kubernetesClusterDomain: cluster.local


please keep the values as generated by helm create as it provides documentation

jouve · 2023-07-10T08:09:53Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+  replicas: {{ .Values.objectstorageController.replicas }}
+  selector:
+    matchLabels:
+      app.kubernetes.io/component: controller


why do you need all these labels in selector.matchLabels ?

jouve · 2023-07-10T08:10:45Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+    metadata:
+      labels:
+        app.kubernetes.io/component: controller
+        app.kubernetes.io/name: container-object-storage-interface-controller


selectorLabels already includes app.kubernetes.io/name

jouve · 2023-07-10T08:11:16Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+        - --v=5
+        env:
+        - name: KUBERNETES_CLUSTER_DOMAIN
+          value: {{ quote .Values.kubernetesClusterDomain }}


most charts I know use .Values.clusterDomain

jouve · 2023-07-10T08:12:52Z

charts/container-object-storage-interface-controller/values.yaml

+kubernetesClusterDomain: cluster.local
+objectstorageController:
+  objectstorageController:
+    image:


too many nesting, as there is only 1 image, I suggest image at the top level (as is the default generated by helm create )

jouve · 2023-07-10T08:15:41Z

charts/container-object-storage-interface-controller/templates/role-rbac.yaml

@@ -0,0 +1,58 @@
+apiVersion: rbac.authorization.k8s.io/v1


its weird that there is the SA in deployment, ClusterRole here and 3 rbac objects in objectstorage-controller-rbac.yaml

jouve · 2023-07-10T08:17:17Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+      labels:
+        app.kubernetes.io/component: controller
+        app.kubernetes.io/name: container-object-storage-interface-controller
+        app.kubernetes.io/part-of: container-object-storage-interface


I think "part-of" is used when you deploy a component as part of something else, but container-object-storage-interface is standalone, so I would remove it

jouve · 2023-07-10T08:17:47Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+        app.kubernetes.io/component: controller
+        app.kubernetes.io/name: container-object-storage-interface-controller
+        app.kubernetes.io/part-of: container-object-storage-interface
+        app.kubernetes.io/version: main


version should be consistent with AppVersion or image.tag, not hardcoded

jouve · 2023-07-10T08:18:45Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+        imagePullPolicy: {{ .Values.objectstorageController.objectstorageController.imagePullPolicy
+          }}
+        name: objectstorage-controller
+        resources: {}


resources should be customizable (as it is with the default from helm create)

jouve · 2023-07-10T08:19:53Z

charts/container-object-storage-interface-controller/templates/deployment.yaml

+metadata:
+  name: {{ include "container-object-storage-interface-controller.fullname" . }}-objectstorage-controller
+  labels:
+    app.kubernetes.io/component: controller


I think component is usefull if there are multiple components in a chart

k8s-triage-robot · 2024-01-21T06:16:01Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-20T06:29:15Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-03-21T07:11:26Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-03-21T07:11:30Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

helm chart addition to cosi-controller

dd8c29b

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>

k8s-ci-robot requested a review from msau42 April 27, 2023 09:44

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2023

k8s-ci-robot requested a review from mukhoakash April 27, 2023 09:44

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 27, 2023

BlaineEXE reviewed Apr 27, 2023

View reviewed changes

thotz mentioned this pull request Jun 22, 2023

object: adding ceph cosi driver rook/rook#12415

Merged

7 tasks

jouve reviewed Jul 10, 2023

View reviewed changes

jouve reviewed Aug 28, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 20, 2024

k8s-ci-robot closed this Mar 21, 2024

helm chart addition to cosi-controller #75

helm chart addition to cosi-controller #75

Uh oh!

Conversation

thotz commented Apr 27, 2023

Uh oh!

k8s-ci-robot commented Apr 27, 2023

Uh oh!

k8s-ci-robot commented Apr 27, 2023

Uh oh!

k8s-ci-robot commented Apr 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jouve Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liangyuanpeng commented Jul 11, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Jan 21, 2024

Uh oh!

k8s-triage-robot commented Feb 20, 2024

Uh oh!

k8s-triage-robot commented Mar 21, 2024

Uh oh!

k8s-ci-robot commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jouve Jul 10, 2023 •

edited

Loading