🐛 Let the envtest apiserver listen also on non-localhost #1844

jkmw · 2022-03-24T13:44:56Z

Currently, the certificate is only issued for localhost. With this PR, the IP from APIServer.SecureServing.ListenAddr.Address is also included, if it exists.

fixes #1751

k8s-triage-robot · 2022-03-24T17:53:45Z

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

k8s-triage-robot · 2022-03-24T19:54:45Z

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

linux-foundation-easycla · 2022-03-24T19:54:49Z

The committers listed above are authorized under a signed CLA.

✅ login: jkmw / name: JK (616b89b)

zawachte · 2022-04-01T18:18:52Z

ty!

varshaprasad96 · 2022-04-04T22:48:27Z

/ok-to-test

varshaprasad96 · 2022-04-04T23:03:40Z

pkg/internal/testing/controlplane/apiserver.go

+	if len(s.SecureServing.Address) > 0 {
+		certNames = append(certNames, s.SecureServing.Address)
+	}
+	servingCerts, err := ca.NewServingCert(certNames...)


Only even when no certnames are passed to ca.NewServingCert(), localhost is getting added by default. Do we modify the condition in pkg/internal/testing/certs/tinyca.go instead of here?

Would also be possible, of course. Should I implement this or is it a consideration for now?

k8s-triage-robot · 2022-07-24T09:31:51Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jkmw · 2022-07-25T14:25:53Z

/remove-lifecycle stale

vincepri · 2022-07-26T16:41:37Z

Can we add a test?

k8s-triage-robot · 2022-10-24T17:32:32Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-11-23T18:02:04Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Haegi · 2022-12-08T08:38:21Z

Are there any updates on this? I would be also willing to help

k8s-triage-robot · 2023-01-07T08:39:19Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-01-07T08:39:23Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Let the envtest apiserver listen also on non-localhost

616b89b

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 24, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 4, 2022

varshaprasad96 reviewed Apr 4, 2022

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 23, 2022

k8s-ci-robot closed this Jan 7, 2023

🐛 Let the envtest apiserver listen also on non-localhost #1844

🐛 Let the envtest apiserver listen also on non-localhost #1844

Uh oh!

Conversation

jkmw commented Mar 24, 2022

Uh oh!

k8s-triage-robot commented Mar 24, 2022

Uh oh!

k8s-triage-robot commented Mar 24, 2022

Uh oh!

linux-foundation-easycla bot commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zawachte commented Apr 1, 2022

Uh oh!

varshaprasad96 commented Apr 4, 2022

Uh oh!

varshaprasad96 Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

jkmw Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Jul 24, 2022

Uh oh!

jkmw commented Jul 25, 2022

Uh oh!

vincepri commented Jul 26, 2022

Uh oh!

k8s-triage-robot commented Oct 24, 2022

Uh oh!

k8s-triage-robot commented Nov 23, 2022

Uh oh!

Haegi commented Dec 8, 2022

Uh oh!

k8s-triage-robot commented Jan 7, 2023

Uh oh!

k8s-ci-robot commented Jan 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

linux-foundation-easycla bot commented Mar 24, 2022 •

edited

Loading