Skip to content

Conversation

@shotarok
Copy link
Contributor

@shotarok shotarok commented Jun 8, 2025

Resolve #598

Update EPP to expose metrics to represent ready inference models to serve. inference_model_ready is a binary metric with the pool_name and model_name labels.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shotarok
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kfswain and robscott June 8, 2025 05:35
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @shotarok. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2025
@netlify
Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5e35bac
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/684b6795925ad20008e0f959
😎 Deploy Preview https://deploy-preview-935--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shotarok shotarok marked this pull request as ready for review June 8, 2025 06:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans June 8, 2025 06:23
@shotarok shotarok changed the title Update EPP to expose metrics to represent inference models Update EPP to expose metrics to represent ready inference models to serve Jun 8, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

overall I’m ok with this change. just a heads up - inferencemodel is during some rework and would probably change significantly. not sure if now is a good timing to add metrics.

#892

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2025
@shotarok
Copy link
Contributor Author

shotarok commented Jun 8, 2025

@nirrozenbaum Thank you for your review and heads up! I understand InferenceModel may change significantly. If it's better to hold this issue for a future version, I'm happy to close this PR and find the other issue to work on.

@nirrozenbaum
Copy link
Contributor

since @ahg-g is leading the effort on InferenceModel redesign, I will let him comment if he thinks we should make progress with this or wait until things get clearer.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 10, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2025
@shotarok
Copy link
Contributor Author

/retest

@nirrozenbaum
Copy link
Contributor

/test pull-gateway-api-inference-extension-test-e2e-main

@shotarok
Copy link
Contributor Author

@ahg-g Hello, I understand InferenceModel deprecation is being discussed in "Revisiting The InferenceModel API". Do you think it's worth merging this PR for the versions until InferenceModel is deprecated? If not, I'll close this PR and add a comment on #598, so please let me know. Thanks!

@kfswain
Copy link
Collaborator

kfswain commented Jun 17, 2025

I'm starting the transition today, so probably okay to hold off.

@shotarok
Copy link
Contributor Author

shotarok commented Jun 17, 2025

@kfswain Thank you for letting me know! Then, I'll close this PR.

@shotarok shotarok closed this Jun 17, 2025
@shotarok shotarok deleted the shotarok/inference-model-ready-metrics branch June 17, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a metric to track InferenceModels ready to serve by the epp

4 participants