Skip to content

Conversation

@EyalPazz
Copy link
Member

@EyalPazz EyalPazz commented Jun 10, 2025

#912 had broken the guide rendering, needed to add raw sections around the templated resources

@netlify
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 9e333ef
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68481e95878581000867f338
😎 Deploy Preview https://deploy-preview-953--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and kfswain June 10, 2025 12:01
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jun 11, 2025

/approve

thanks, pls address the conflict

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, EyalPazz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 11, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EyalPazz
Copy link
Member Author

EyalPazz commented Jun 11, 2025

#954 fixed it

@EyalPazz EyalPazz closed this Jun 11, 2025
@EyalPazz EyalPazz deleted the fix-metrics-guide branch June 12, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants