Skip to content

Conversation

@briantkennedy
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix some wording issues my linter is complaining about.

Which issue(s) this PR fixes:
N/A, very tiny change.

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @briantkennedy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2023
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2023
@robscott
Copy link
Member

robscott commented Feb 1, 2023

Thanks @briantkennedy! It looks like you need to run make generate to get tests to pass, otherwise LGTM.

@shaneutt shaneutt added this to the v0.6.2 milestone Mar 8, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@shaneutt
Copy link
Member

shaneutt commented Mar 8, 2023

@briantkennedy since we hadn't heard back from you in a while, I added the one-line missing from the make generate so we could go ahead and get this merged. Thank you for your contribution!

Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briantkennedy, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt changed the title Fix trivial workding issues. Fix trivial wording issues. Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 905f32d into kubernetes-sigs:main Mar 8, 2023
@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 14, 2023
@briantkennedy briantkennedy deleted the nit branch June 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants