-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add bash installation script for macos or linux users. #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cmoulliard
commented
Nov 16, 2018
- Add bash installation script for macos or linux users.
- download . latest version of the project or specific version, untar it and move project under /usr/local/bin/kubebuilder
- Fix [Feature] Bash install script #482
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cmoulliard If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cmoulliard Its blocked on CLA. |
|
I tried many times to get an email's validation from "linuxfoundation" to create an account for the ICLA since yesterday without success. |
|
|
||
| echo "Downloaded these executable files into $NAME: " | ||
| ls "${NAME}_${OSEXT}_${ARCH}/bin" | ||
| sudo mv ${NAME}_${OSEXT}_${ARCH} /usr/local/kubebuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has changed to the following line in #470.
mv kubebuilder_${version}darwin${arch} kubebuilder && sudo mv kubebuilder /usr/local/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If /usr/local/kubebuilder folder already exists, then we can't use mv kubebuilder /usr/local directly but a sudo rm -rf /usr/local/kubebuilder will be first needed. Instead of doing that, we could also rsync folders -> rsync -avh ./kubebuilder/ /usr/local/kubebuilder ? WDYT @hidekazuna ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If /usr/local/kubebuilder directory already exists, it is better to warn it and stop executing than force installing.
If force Installing, kubebuilder may be upgraded or downgraded unintentionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. We will then exit in this case and add a warning message to the user that prior to upgrade, in this case, they have to first delete the existing folder or backup it.
|
As my PR contains 2 non needed commits, I will close this one submit a new PR if you agree including also the modifications requested for the bash script -> https://github.com/cmoulliard/kubebuilder/commit/b85612e657c9ab0b56506b085a0e1c89dc76f0ec |
|
New PR will be submitted |