Skip to content

Conversation

@cmoulliard
Copy link
Contributor

  • Add bash installation script for macos or linux users.
  • download . latest version of the project or specific version, untar it and move project under /usr/local/bin/kubebuilder
  • Fix [Feature] Bash install script #482

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cmoulliard
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mengqiy

If they are not already assigned, you can assign the PR to them by writing /assign @mengqiy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2018
@droot
Copy link
Contributor

droot commented Nov 16, 2018

@cmoulliard Its blocked on CLA.

@cmoulliard
Copy link
Contributor Author

I tried many times to get an email's validation from "linuxfoundation" to create an account for the ICLA since yesterday without success.


echo "Downloaded these executable files into $NAME: "
ls "${NAME}_${OSEXT}_${ARCH}/bin"
sudo mv ${NAME}_${OSEXT}_${ARCH} /usr/local/kubebuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has changed to the following line in #470.
mv kubebuilder_${version}darwin${arch} kubebuilder && sudo mv kubebuilder /usr/local/

Copy link
Contributor Author

@cmoulliard cmoulliard Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If /usr/local/kubebuilder folder already exists, then we can't use mv kubebuilder /usr/local directly but a sudo rm -rf /usr/local/kubebuilder will be first needed. Instead of doing that, we could also rsync folders -> rsync -avh ./kubebuilder/ /usr/local/kubebuilder ? WDYT @hidekazuna ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If /usr/local/kubebuilder directory already exists, it is better to warn it and stop executing than force installing.
If force Installing, kubebuilder may be upgraded or downgraded unintentionally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. We will then exit in this case and add a warning message to the user that prior to upgrade, in this case, they have to first delete the existing folder or backup it.

@cmoulliard
Copy link
Contributor Author

cmoulliard commented Nov 20, 2018

As my PR contains 2 non needed commits, I will close this one submit a new PR if you agree including also the modifications requested for the bash script -> https://github.com/cmoulliard/kubebuilder/commit/b85612e657c9ab0b56506b085a0e1c89dc76f0ec
@hidekazuna

@cmoulliard
Copy link
Contributor Author

New PR will be submitted

@cmoulliard cmoulliard closed this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants