Cilium service topology config

[spantazi]

What would you like to be added

Configuration of cilium networking is missing loadBalancer.serviceTopology key, which is required by cilium to enable traffic distribution and topology aware routing.

Why is this needed

Ability to configure the traffic distribution between deployed applications (if that feature is supported by the CNI, which is the case for modern kubernetes and cilium versions) is valuable in kubernetes installations.

[spantazi]

Found a way to support this.

In https://github.com/kubernetes-sigs/kubespray/blob/master/roles/network_plugin/cilium/templates/cilium/config.yml.j2

should add

`
{% if cilium_enable_service_topology %}

enable-service-topology: "{{ cilium_enable_service_topology }}"

{% endif %}
`

and in you inventory (based on sample at https://github.com/kubernetes-sigs/kubespray/blob/master/inventory/sample/group_vars/k8s_cluster/k8s-net-cilium.yml)
,add

cilium_enable_service_topology: true

[tico88612]

This version has updated the cilium installation method, which needs to be added to the cilium values file.

Add this on roles/network_plugin/cilium/templates/values.yaml.j2:

loadBalancer:
  serviceTopology: {{ cilium_loadbalancer_service_topology }}

and add this on roles/network_plugin/cilium/defaults/main.yml as default value:

cilium_loadbalancer_service_topology: false

[tico88612]

/good-first-issue

I think it should not take long to implement this. (maybe 2 days)

[k8s-ci-robot]

@tico88612:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

Details

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[prennig86]

Hello,

in addition, in roles/network_plugin/cilium/templates/values.yaml.j2 there are many variables that are missing if you check the original cilium values file, in my case i need "egressGateway.enabled"

https://github.com/cilium/cilium/blob/v1.17.3/install/kubernetes/cilium/values.yaml#L2071

Is possible to have available all original helm values paramenter?

[tico88612]

Is possible to have available all original helm values paramenter?

Nope, Cilium has a lot of default values, so it is impossible to list them all in the Kubespray project, so please open issues and PRs and explanation (why you need?) if you need them.

[cleman95]

Hi @tico88612 can you assign me ? I'd like to contribute.

[tico88612]

/assign @cleman95
Go ahead!