tide merges PRs when failed GitHub Actions are retried

[dprotaso]

Prior in test/infra issue: kubernetes/test-infra#28860

I just had a PR in Knative serving that was failed - knative/serving#15668

When I triggered the actions to re-run all github actions tide merged the PR in

In the picture you can see the 'build' step is running

[dprotaso]

The checks aren't required - but I wouldn't assume tide would merge while there were actions in a 'running' state

[smg247]

Have you verified your context policy options. You may have something set up incorrectly there. It would be useful to see what you have configured.

[petr-muller]

Looks like #337 is the same thing

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[petr-muller]

/remove-lifecycle rotten

[dprotaso]

/lifecycle frozen

I just encountered a related scenario. Opened a PR against a release branch where we have no prow jobs. We do have gating github actions that should prevent the merge. But tide just merged the PR without waiting for the Github Actions to complete.

[petr-muller]

/area tide
/kind bug