feat: add mutli-arch Dockerfile by manzil-infinity180 · Pull Request #66 · kubernetes-sigs/testgrid

manzil-infinity180 · 2025-08-21T19:40:30Z

fixes #5

Added dockerfile and docker-compose.yaml file

did some changes to rollup.config.js to replaces process.env.* during the build step.

added .env into.gitignore
added docs for build & run the testgrid

k8s-ci-robot · 2025-08-21T19:40:40Z

Hi @manzil-infinity180. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

manzil-infinity180 · 2025-08-21T19:41:28Z

web/docker-compose.yml

+      - "8080:80"
+    environment:
+      # - API_HOST=testgrid-data.k8s.io
+      - API_HOST=host.docker.internal


manzil-infinity180 · 2025-08-21T19:42:58Z

Need to test once for the local fake JSON and then it is good to go for review

manzil-infinity180 · 2025-08-22T17:03:06Z

Hi @ameukam @michelle192837
Could you please take a look at this PR?
Thanks

ameukam · 2025-08-22T17:22:32Z

/ok-to-test

manzil-infinity180 · 2025-08-23T00:47:15Z

/retest

ameukam · 2025-08-23T06:55:06Z

/lgtm

ameukam · 2025-08-23T07:00:41Z

The mechanics of building and pushing to a community-owned Docker repository are not trivial.
I'll take care of that.

A follow-up would be to have A Github Action that trigger a build (without push) of the Dockerfile.
@michelle192837 WDYT ?

michelle192837

I have a bunch of writing nitpicks but otherwise this looks fine to me!

michelle192837 · 2025-08-25T18:40:01Z

web/README.md

+
+## Build & Run with Docker
+
+- `docker compose up --build` Spins up the frontend container. A local `json-server` which serves the data from `src/fake-api/data.json` file. The frontend (via pnpm local-server) connects to it at `http://localhost:3000/`


...: Spins...

and

...container, a local...

michelle192837 · 2025-08-25T18:43:55Z

web/README.md

+
+- `docker compose up --build` Spins up the frontend container. A local `json-server` which serves the data from `src/fake-api/data.json` file. The frontend (via pnpm local-server) connects to it at `http://localhost:3000/`
+
+- If you want to external k8s Testgrid API instance - actual data. Uncomment the args from the `Dockerfile`. It is need on the build time, thats why we are passing inside the Dockerfile. You can visit on the `localhost:8080`


If you want to use the external k8s TestGrid API instance with actual data:

michelle192837 · 2025-08-25T18:45:10Z

web/README.md

+  --build-arg API_PORT=80
+docker compose up
+```
+- Option 2: → uncomment the `args:` block in your compose file


Option 2: Uncomment...

michelle192837 · 2025-08-25T18:45:49Z

web/README.md

+- `docker compose up --build` Spins up the frontend container. A local `json-server` which serves the data from `src/fake-api/data.json` file. The frontend (via pnpm local-server) connects to it at `http://localhost:3000/`
+
+- If you want to external k8s Testgrid API instance - actual data. Uncomment the args from the `Dockerfile`. It is need on the build time, thats why we are passing inside the Dockerfile. You can visit on the `localhost:8080`
+- Option 1: Using CLI --build-arg


nit: Indent both Options 1 and 2?

michelle192837 · 2025-08-25T18:47:24Z

web/docker-compose.yml

+    build:
+      context: .
+      dockerfile: Dockerfile
+      # args:


nit: Add a comment here noting when to uncomment (e.g. # Uncomment \args` to use the public TestGrid API.`)

michelle192837 · 2025-08-25T18:53:05Z

The mechanics of building and pushing to a community-owned Docker repository are not trivial. I'll take care of that.

A follow-up would be to have A Github Action that trigger a build (without push) of the Dockerfile. @michelle192837 WDYT ?

Thanks Arnaud!

That sounds fine to me; do we have examples of this from other parts of the project?

ameukam · 2025-08-25T19:44:06Z

The mechanics of building and pushing to a community-owned Docker repository are not trivial. I'll take care of that.
A follow-up would be to have A Github Action that trigger a build (without push) of the Dockerfile. @michelle192837 WDYT ?

Thanks Arnaud!

That sounds fine to me; do we have examples of this from other parts of the project?

You can check this cloudbuild spec as an example.

michelle192837 · 2025-08-25T21:21:29Z

The mechanics of building and pushing to a community-owned Docker repository are not trivial. I'll take care of that.
A follow-up would be to have A Github Action that trigger a build (without push) of the Dockerfile. @michelle192837 WDYT ?

Thanks Arnaud!
That sounds fine to me; do we have examples of this from other parts of the project?

You can check this cloudbuild spec as an example.

Oh yeah that part makes sense, I'm more confused about whether we're using GHA in other parts as opposed to a Prow job. (As far as I'm aware Prow jobs are still the recommendation but if we're using GHA for some things happy to try that out).

ameukam · 2025-08-25T21:57:52Z

The mechanics of building and pushing to a community-owned Docker repository are not trivial. I'll take care of that.
A follow-up would be to have A Github Action that trigger a build (without push) of the Dockerfile. @michelle192837 WDYT ?

Thanks Arnaud!
That sounds fine to me; do we have examples of this from other parts of the project?

You can check this cloudbuild spec as an example.

Oh yeah that part makes sense, I'm more confused about whether we're using GHA in other parts as opposed to a Prow job. (As far as I'm aware Prow jobs are still the recommendation but if we're using GHA for some things happy to try that out).

Apologies! You are right. We should stick to Prow jobs for consistency

michelle192837

Looks great, thanks! :D

/lgtm

k8s-ci-robot · 2025-08-26T17:47:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manzil-infinity180, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from jbpratt and michelle192837 August 21, 2025 19:40

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2025

manzil-infinity180 marked this pull request as draft August 21, 2025 19:40

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2025

manzil-infinity180 commented Aug 21, 2025

View reviewed changes

manzil-infinity180 force-pushed the new-dockerfile branch from d68c9dc to 47abe3e Compare August 22, 2025 16:55

manzil-infinity180 marked this pull request as ready for review August 22, 2025 16:58

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025

k8s-ci-robot assigned ameukam Aug 23, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2025

michelle192837 reviewed Aug 25, 2025

View reviewed changes

feat: added Dockerfile and docker compose file

1cec5c6

manzil-infinity180 force-pushed the new-dockerfile branch from 47abe3e to 1cec5c6 Compare August 26, 2025 13:05

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025

michelle192837 approved these changes Aug 26, 2025

View reviewed changes

k8s-ci-robot assigned michelle192837 Aug 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025

k8s-ci-robot merged commit ad1fd0e into kubernetes-sigs:main Aug 26, 2025
3 checks passed

manzil-infinity180 deleted the new-dockerfile branch August 26, 2025 18:00

manzil-infinity180 mentioned this pull request Sep 1, 2025

REQUEST: New membership for manzil-infinity180 kubernetes/org#5805

Closed

11 tasks


		## Build & Run with Docker

		- `docker compose up --build` Spins up the frontend container. A local `json-server` which serves the data from `src/fake-api/data.json` file. The frontend (via pnpm local-server) connects to it at `http://localhost:3000/`


		- `docker compose up --build` Spins up the frontend container. A local `json-server` which serves the data from `src/fake-api/data.json` file. The frontend (via pnpm local-server) connects to it at `http://localhost:3000/`

		- If you want to external k8s Testgrid API instance - actual data. Uncomment the args from the `Dockerfile`. It is need on the build time, thats why we are passing inside the Dockerfile. You can visit on the `localhost:8080`

Conversation

manzil-infinity180 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 21, 2025

Uh oh!

manzil-infinity180 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

manzil-infinity180 commented Aug 21, 2025

Uh oh!

manzil-infinity180 commented Aug 22, 2025

Uh oh!

ameukam commented Aug 22, 2025

Uh oh!

manzil-infinity180 commented Aug 23, 2025

Uh oh!

ameukam commented Aug 23, 2025

Uh oh!

ameukam commented Aug 23, 2025

Uh oh!

michelle192837 left a comment

Choose a reason for hiding this comment

Uh oh!

michelle192837 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michelle192837 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michelle192837 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michelle192837 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michelle192837 Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

michelle192837 commented Aug 25, 2025

Uh oh!

ameukam commented Aug 25, 2025

Uh oh!

michelle192837 commented Aug 25, 2025

Uh oh!

ameukam commented Aug 25, 2025

Uh oh!

michelle192837 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manzil-infinity180 commented Aug 21, 2025 •

edited

Loading