include pod namespace when logging updates

[voelzmo]

What type of PR is this?

What this PR does / why we need it:

include pod namespace when logging updates. Useful to differentiate between Pods with the same name in different namespaces.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

include pod namespace when logging updates.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[ialidzhikov]

/lgtm

[adrianmoisey]

/close
(going to re-open to re-run the tests)

[k8s-ci-robot]

@adrianmoisey: Closed this PR.

Details

In response to this:

/close
(going to re-open to re-run the tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adrianmoisey]

/reopen

[k8s-ci-robot]

@adrianmoisey: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[omerap12]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, omerap12, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [omerap12,voelzmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ialidzhikov]

I see that the failed tests are CA ones:

--- FAIL: TestDeleteInstances (155.07s)
    azure_agent_pool_test.go:426: 
        	Error Trace:	/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/cloudprovider/azure/azure_agent_pool_test.go:426
        	Error:      	Should be true
        	Test:       	TestDeleteInstances
        	
...

--- FAIL: TestAgentPoolDeleteNodes (155.13s)
    azure_agent_pool_test.go:482: 
        	Error Trace:	/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/cloudprovider/azure/azure_agent_pool_test.go:482
        	Error:      	Should be true
        	Test:       	TestAgentPoolDeleteNodes

---

Does someone has permissions to retry the failed GitHub action as the failure is not related to a change from this PR? @raywainman, @adrianmoisey ? 🤔

[adrianmoisey]

Does someone has permissions to retry the failed GitHub action as the failure is not related to a change from this PR? @raywainman, @adrianmoisey ? 🤔

It seems to be a permanent fail (not a flake). I've asked in sig-autoscaling about it: https://kubernetes.slack.com/archives/C09R1LV8S/p1749291473204429
I'll also bring it up in the sig-autoscaling meeting today

[ialidzhikov]

I created an issue for the failing unit test - #8216. Later on, I saw that there is a already a PR to fix it - #8213.

[ialidzhikov]

/cherry-pick vpa-release-1.4

[k8s-infra-cherrypick-robot]

@ialidzhikov: once the present PR merges, I will cherry-pick it on top of vpa-release-1.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick vpa-release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ialidzhikov]

/cherry-pick vpa-release-1.3

[k8s-infra-cherrypick-robot]

@ialidzhikov: once the present PR merges, I will cherry-pick it on top of vpa-release-1.3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick vpa-release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ialidzhikov]

/cherry-pick vpa-release-1.2

[k8s-infra-cherrypick-robot]

@ialidzhikov: once the present PR merges, I will cherry-pick it on top of vpa-release-1.2 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick vpa-release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adrianmoisey]

/close

[k8s-ci-robot]

@adrianmoisey: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adrianmoisey]

/reopen

[k8s-ci-robot]

@adrianmoisey: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adrianmoisey]

The Github actions tests have passed, I think this will merge soon

[k8s-infra-cherrypick-robot]

@ialidzhikov: new pull request created: #8226

Details

In response to this:

/cherry-pick vpa-release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@ialidzhikov: new pull request created: #8227

Details

In response to this:

/cherry-pick vpa-release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@ialidzhikov: #8204 failed to apply on top of branch "vpa-release-1.2":

Applying: include pod namespace when logging updates
Using index info to reconstruct a base tree...
M	vertical-pod-autoscaler/pkg/admission-controller/resource/pod/recommendation/recommendation_provider.go
Falling back to patching base and 3-way merge...
Auto-merging vertical-pod-autoscaler/pkg/admission-controller/resource/pod/recommendation/recommendation_provider.go
CONFLICT (content): Merge conflict in vertical-pod-autoscaler/pkg/admission-controller/resource/pod/recommendation/recommendation_provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 include pod namespace when logging updates

Details

In response to this:

/cherry-pick vpa-release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.