Skip to content

Automated cherry pick of #1374: fix: Add explicit HTTP request timeouts to all AWS SDK#1438

Merged
k8s-ci-robot merged 5 commits into
kubernetes:release-1.33from
howard-junec:automated-cherry-pick-of-#1374-upstream-release-1.33
May 10, 2026
Merged

Automated cherry pick of #1374: fix: Add explicit HTTP request timeouts to all AWS SDK#1438
k8s-ci-robot merged 5 commits into
kubernetes:release-1.33from
howard-junec:automated-cherry-pick-of-#1374-upstream-release-1.33

Conversation

@howard-junec
Copy link
Copy Markdown
Contributor

@howard-junec howard-junec commented May 8, 2026 •
edited
Loading

Cherry pick of #1374 and #1377 on release-1.33.

#1374: fix: Add explicit HTTP request timeouts to all AWS SDK

For details on the cherry pick process, see the cherry pick requests page.

Added explicit HTTP request timeouts (30s) to all AWS SDK clients to prevent clock skew overcorrection from slow API responses.
Added cloudprovider_aws_api_response_status_total metric to track AWS API response status codes (4xx/5xx).

@howard-junec
fix: Add explicit HTTP request timeouts to all AWS SDK clients
fb5f42d 
Configure WithHTTPClient on all LoadDefaultConfig calls to prevent
clock skew overcorrection from slow API responses (COE-389792).
Add AST test to ensure future SDK clients include timeout.
@howard-junec
Use SDK BuildableClient for HTTP timeouts
09d115a 
Replace http.Client with awshttp.NewBuildableClient().WithTimeout()
to preserve SDK default transport settings.
@howard-junec
Fix gofmt formatting
ce5ef2c
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2026
@k8s-ci-robot k8s-ci-robot requested review from hakman and nckturner May 8, 2026 05:19
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 8, 2026

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 8, 2026

Hi @howard-junec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented May 8, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 8, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented May 10, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 563bb52 into kubernetes:release-1.33 May 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@howard-junec @k8s-ci-robot @kmala