Skip to content

Update merge requirements in doc #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Update merge requirements in doc #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions contributors/devel/automation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,9 @@ The status of the submit-queue is [online.](http://submit-queue.k8s.io/)

The submit-queue lists what it believes are required on the [merge requirements tab](http://submit-queue.k8s.io/#/info) of the info page. That may be more up to date.

A PR is considered "ready for merging" if it matches the following:
* The PR must have the label `cncf-cla: yes` or `cla: human-approved`
* The PR must be mergeable, aka cannot need a rebase
* All of the required github CI tests must be green. The current list of tests are on the [MERGE REQUIREMENTS tab, at this link](https://submit-queue.k8s.io/#/info)
* The PR cannot have any prohibited future milestones (such as a v1.5 milestone during v1.4 code freeze)
* The PR must have the `lgtm` label. The `lgtm` label is automatically applied
following a review comment consisting of `/lgtm` (case-insensitive) in a single line
* The PR must not have been updated since the `lgtm` label was applied
* The PR must have the `approved` label. The `approved` label is automatically
applied after all approvers have approved the PR by a comment consisting of
`/approve` (case-insensitive) in a single line
* The PR must not have the `do-not-merge` label or any of other `do-not-merge/*`
labels, e.g., `do-not-merge/release-note-label-needed`
A PR is considered "ready for merging" by the submit queue if it matches the set
of conditions listed in the merge requirements tab mentioned above.
Please visit that page for more details.

### Merge process

Expand Down