-
Notifications
You must be signed in to change notification settings - Fork 5.3k
add document about HostPath volume propagation mode #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thockin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I feel as if several of my comments weren't properly addressed. Most notably, I feel like we needed discussion about the implications of "silent failure" on a misconfigured node (per my comment kubernetes/kubernetes#37276 (comment)). |
| return "" | ||
| } | ||
| if container.SecurityContext.Privileged { | ||
| return "rshared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not consistent with the proposal itself and the decision below, as rshared is not the same as shared.
|
From a runtime/node point of view, I'm concerned by this proposal because it completely skips discussing complex topics such as:
(most of those have been highlighted by @euank before) rkt/rkt#3465 (and references therein) may be a good starting point for reading about real-world issues related to (some) of the above topics. |
|
@lucab @euank These concerns are valid, that's why we explicitly restricted this proposal to HostPath. In the scene of HostPath, I think the side-effects you mentioned is just the design. In HostPath volume, any runtime should NOT perform any additional action (such as clean up) other than the bind mount. |
|
@lvlv can you file a follow-up PR that adds these notes? |
|
@lvlv I need the comments addressed. I hit the merge too fast since comments were lost during the repo move. My fault. |
Adds release note for DNS Horizontal Autoscaling
Move from kubernetes/kubernetes#37276
What this PR does / why we need it:
Add a design doc about HostPath volume propagation
Special notes for your reviewer:
As discussed in kubernetes/kubernetes#31504, I created a document about our use cases and our alternative implementations.