Skip to content

Design document for gRPC-based KMS plugin service #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2018
Merged

Design document for gRPC-based KMS plugin service #1581

merged 2 commits into from
Jan 16, 2018

Conversation

@wu-qiang
Copy link
Contributor

@wu-qiang wu-qiang commented Jan 9, 2018

This document describes the gRPC interface between API server and out-of-tree KMS provider.

  • Define the protobuf file for the gRPC interface
  • Communicate with unix domain socket, not support TCP, so no TLS support
  • The configuration file

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2018
@k8s-github-robot k8s-github-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jan 9, 2018
@wu-qiang
Copy link
Contributor Author

wu-qiang commented Jan 9, 2018

@destijl Should this document be a part of #607?

@wu-qiang wu-qiang mentioned this pull request Jan 9, 2018
Merged
@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2018

This was open as google doc for quite some time and discussed multiple times at sig-auth. There were no dissenters in either spot. I plan to tag tomorrow unless some speaks up today.

lgtm

@deads2k
Copy link
Contributor

deads2k commented Jan 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, wu-qiang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2018
@deads2k
Copy link
Contributor

deads2k commented Jan 16, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7d35802 into kubernetes:master Jan 16, 2018
@enj enj mentioned this pull request Dec 11, 2019
Closed
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
@k8s-ci-robot
Merge pull request kubernetes#1581 from oracle/for/upstream/master/km…
bfc25a5 
…s-plugin-grpc-api

Design document for gRPC-based KMS plugin service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ericchiang ericchiang Awaiting requested review from ericchiang

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wu-qiang @deads2k @k8s-ci-robot @k8s-github-robot