GitHub Management Docs #2277

cblecker · 2018-06-17T05:51:59Z

partial fix for #2126.

This PR collects the GitHub management documents in a single directory, and adds a first revision of a document describing GitHub permission levels.

/cc @spiffxp @jdumars @grodrigues3

cblecker · 2018-06-21T03:00:57Z

@kubernetes/steering-committee @spiffxp @grodrigues3 @jdumars @idvoretskyi @calebamiles

If any of you want to have a look at this, I'd appreciate it :)

idvoretskyi · 2018-06-21T08:36:32Z

/assign

idvoretskyi · 2018-06-21T13:53:53Z

/hold

for another pair of eyes :)

idvoretskyi

/lgtm

grodrigues3

A few small comments, but in general LGTM. Thanks @cblecker

grodrigues3 · 2018-06-26T17:46:04Z

github-management/README.md

+| [kubernetes](https://github.com/kubernetes) | Core |
+| [kubernetes-client](https://github.com/kubernetes-client) | API Client Libraries |
+| [kubernetes-csi](https://github.com/kubernetes-csi) | Container Storage Interface Components |
+| [kubernetes-incubator](https://github.com/kubernetes-incubator) | Legacy Incubator Projects |


Is this still active? Don't we want to suggest kubernetes-sigs (subprojects) instead?

https://github.com/kubernetes/community/blob/master/incubator.md

It's still active in that there are still repos there, and the steering committee isn't pushing them to migrate anywhere right now. If it's in incubator, it can stay there for the time being, but no new projects will be added.

grodrigues3 · 2018-06-26T17:47:02Z

github-management/README.md

+repositories and organizations:
+- [branchprotector](https://git.k8s.io/test-infra/prow/cmd/branchprotector):
+  enforce branch protection settings across an organization
+- [label_sync](https://git.k8s.io/test-infra/label_sync): Add, modify, delete,


call out that it's within an organization and across multiple repositories.

grodrigues3 · 2018-06-26T17:47:58Z

github-management/README.md

+There are more organization names that we are squatting on with possible future
+intentions. [For more details please see community issue #1407](https://github.com/kubernetes/community/issues/1407).
+
+## Tooling


Don't want to call out prow/tide? The plugins and bot commands that we use are not obvious

grodrigues3 · 2018-06-26T17:51:08Z

github-management/permissions.md

+scale well with the size and velocity of the Kubernetes project.
+
+We have created a number of automated systems/bots to allow us to work around
+these limitations. Authorized users can issue


link to our owners/approvers documentation?

cblecker · 2018-06-26T19:00:15Z

@grodrigues3 Comments addressed. PTAL

bgrant0607 · 2018-06-26T19:50:30Z

github-management/README.md

+| [kubernetes-incubator](https://github.com/kubernetes-incubator) | Legacy Incubator Projects |
+| [kubernetes-retired](https://github.com/kubernetes-retired) | Retired/Archived Projects |
+| [kubernetes-security](https://github.com/kubernetes-security) | Private Security Fix Mirror |
+| [kubernetes-sigs](https://github.com/kubernetes-security) | SIG-related Projects |


Link is wrong

bgrant0607 · 2018-06-26T19:51:10Z

github-management/README.md

+| [kubernetes-extensions](https://github.com/kubernetes-extensions) |  |
+| [kubernetes-federation](https://github.com/kubernetes-federation) |  |
+| [kubernetes-graveyard](https://github.com/kubernetes-graveyard) | kubernetes-retired should be used instead going forward |
+| [kubernetes-incubator-retired](https://github.com/kubernetes-incubator-retired) |  |


kubernetes-retired should be used instead going forward

bgrant0607 · 2018-06-26T19:59:48Z

Thanks. This is a great start. There are some details missing (org-level settings, org-level projects, private repos, external collaborators, team management, ...), but they can be added over time, as necessary.

Read access: Public repos already give access to code, issues, etc.

Membership allows people to see team members, notify teams, be added to teams, have issues and PRs assigned to them, and get the Member "badge" on their comments.

cblecker · 2018-06-27T18:14:41Z

/hold cancel
/approve

@bgrant0607 @grodrigues3 Comments addressed :) Can I get a LGTM?

k8s-ci-robot · 2018-06-27T18:14:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bgrant0607 · 2018-06-28T14:39:29Z

/lgtm

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2018

k8s-ci-robot requested a review from grodrigues3 June 17, 2018 05:52

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2018

k8s-ci-robot requested review from jdumars and spiffxp June 17, 2018 05:52

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2018

cblecker mentioned this pull request Jun 20, 2018

Adding a new sigs directory #2283

Closed

Move existing github related docs to dedicated folder

9ce2bdc

cblecker force-pushed the github-mgmt branch from 2a3693b to 34dc7a8 Compare June 21, 2018 02:52

cblecker changed the title ~~[WIP] GitHub Management Docs~~ GitHub Management Docs Jun 21, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2018

k8s-ci-robot assigned idvoretskyi Jun 21, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2018

idvoretskyi approved these changes Jun 21, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2018

grodrigues3 reviewed Jun 26, 2018

View reviewed changes

cblecker force-pushed the github-mgmt branch from 34dc7a8 to 4003cf2 Compare June 26, 2018 18:58

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2018

cblecker force-pushed the github-mgmt branch from 4003cf2 to 6ef58bd Compare June 26, 2018 18:59

bgrant0607 reviewed Jun 26, 2018

View reviewed changes

cblecker added 3 commits June 26, 2018 12:52

Add README to github-management

5d63534

Add GitHub Permissions doc

402037e

Add minor changes to repo guidelines

a9ef298

cblecker force-pushed the github-mgmt branch from 6ef58bd to a9ef298 Compare June 26, 2018 19:56

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2018

k8s-ci-robot assigned bgrant0607 Jun 28, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018

k8s-ci-robot merged commit 5fa7e3e into kubernetes:master Jun 28, 2018

cblecker deleted the github-mgmt branch June 28, 2018 16:20

wking mentioned this pull request Jul 1, 2018

*: Assorted internal-reference cleanups #2174

Closed

Uh oh!

GitHub Management Docs #2277

GitHub Management Docs #2277

Uh oh!

Conversation

cblecker commented Jun 17, 2018

Uh oh!

cblecker commented Jun 21, 2018

Uh oh!

idvoretskyi commented Jun 21, 2018

Uh oh!

idvoretskyi commented Jun 21, 2018

Uh oh!

idvoretskyi left a comment

Choose a reason for hiding this comment

Uh oh!

grodrigues3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cblecker commented Jun 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bgrant0607 commented Jun 26, 2018

Uh oh!

cblecker commented Jun 27, 2018

Uh oh!

k8s-ci-robot commented Jun 27, 2018

Uh oh!

bgrant0607 commented Jun 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants